device-nokia-n900: switch speaker/headset with jack detection

I've extended the acpi handler to switch betweek speaker and headset configurations when the jack is inserted/removed.

I've also added a script to load the speaker configuration on boot.

Configurations based on the files provided by NikkSann (#702 (comment))

Closes #132 (closed)

changed the description

By Daniele Debernardi on 2020-03-22T00:28:50

added 1 commit

• 753b8935 - device-nokia-n900: switch speaker/headset with jack detection

Compare with previous version

By Daniele Debernardi on 2020-03-22T00:31:37

added category::device type::feature labels

I'm a bit confused about the relation of Nokia N900 and ACPI... As a rather old embedded device I cannot really believe that it has ACPI support.

It seems more like acpid is just used as a generic daemon that processes (Linux) input events (even though it is primarily designed to handle ACPI events). Most of the input events, in particular the power key and volume keys should be handled in a generic way (usually by the desktop environment), not in the device package.

In general the same applies to the headphone insertion/removal events. I would expect PulseAudio to switch between speaker and headphones based on available UCM profiles.

I suppose the change in this MR are fine as a temporary measure until we have a proper UCM profile for N900. But if acpid is really just used as a handler for generic input events we should try to trim down the configuration a bit. (The keypad backlight stuff is probably fine as device-specific part...)

By Minecrell on 2020-03-26T18:09:48

approved this merge request

By Alexey Min on 2020-03-26T21:35:32

@Minecrell wrote:

I don't mind if we merge this as temporary solution. I'm just trying to avoid adding too many generic concepts to device-specific packages. It often seems easier initially, but it complicates setting up new devices because suddenly you need to duplicate a lot of configuration.

I agree with you. Merging. Thanks a lot, @drebrez!

FWIW, I had opened an issue to make the ACPI scripts used in the N900 device package generic for all devices (#131 (closed)). But I'm not sure anymore how much value we would have from this if it was implemented. Or if we should just let pulseaudio or the DEs handle such events. (But let's discuss that in the related issue, not here )

By Oliver Smith on 2020-03-29T17:06:12

approved this merge request

By Oliver Smith on 2020-03-29T17:05:53

resolved all threads

By Oliver Smith on 2020-03-29T17:06:01

mentioned in commit f2fed1f6

By Daniele Debernardi on 2020-03-29T17:08:02

added 33 commits

• 753b8935...e8892392 - 32 commits from branch master
• f2fed1f6 - device-nokia-n900: switch speaker/headset with jack detection (!1087 (merged))

Compare with previous version

By Oliver Smith on 2020-03-29T17:08:03

enabled an automatic merge when the pipeline for f2fed1f6 succeeds

By Oliver Smith on 2020-03-29T17:08:24

merged

By Oliver Smith on 2020-03-29T17:11:12