Skip to content
Snippets Groups Projects

main/postmarketos-mkinitfs: remove cache and improve performance

Merged Imported Administrator requested to merge feature/postmarketos-mkinitfs-extra-improvements into master
All threads resolved!

The lddtree script uses the scanelf utility which has some security check that causes a slowdown of the operation, executing it without privileges it's really faster.

Thanks to the speed improvement we can remove the whole caching mechanism and this solves also the issue of the dependencies not hashed.

Comparison between running lddtree as root or as nobody:
as root: time lddtree -l $BINARIES_EXTRA
as nobody: time su nobody -s /bin/sh -c "lddtree -l $(echo $BINARIES_EXTRA)"

in native chroot:

  • as root: 48s
  • as nobody: 0.8s

in qemu armv7:

  • as root: 1m 12s
  • as nobody: 23s

Closes !1100 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator added 1 commit · Imported

    added 1 commit

    • 9967f9aa - main/postmarketos-mkinitfs: execute lddtree without privileges

    Compare with previous version

    By Daniele Debernardi on 2020-04-08T20:43:24

  • Administrator resolved all threads · Imported

    resolved all threads

    By Minecrell on 2020-04-09T07:23:40

  • Administrator approved this merge request · Imported

    approved this merge request

    By Minecrell on 2020-04-09T07:23:42

  • Administrator approved this merge request · Imported

    approved this merge request

    By Bart Ribbers on 2020-04-09T08:33:49

  • Administrator mentioned in commit 36f15b58 · Imported

    mentioned in commit 36f15b58

    By Daniele Debernardi on 2020-04-09T08:35:40

  • Administrator mentioned in commit bd15afc2 · Imported

    mentioned in commit bd15afc2

    By Daniele Debernardi on 2020-04-09T08:35:41

  • Administrator added 3 commits · Imported

    added 3 commits

    Compare with previous version

    By Bart Ribbers on 2020-04-09T08:35:42

  • Administrator enabled an automatic merge when the pipeline for bd15afc2 succeeds · Imported

    enabled an automatic merge when the pipeline for bd15afc2 succeeds

    By Bart Ribbers on 2020-04-09T08:36:01

  • Administrator merged · Imported

    merged

    By Bart Ribbers on 2020-04-09T08:37:22

  • Administrator mentioned in merge request !1100 (closed) · Imported

    mentioned in merge request !1100 (closed)

    By Daniele Debernardi on 2020-04-12T00:17:43

  • Please register or sign in to reply
    Loading