Skip to content
Snippets Groups Projects

samsung-i9003: Change armhf to armv7 and heimdall-isorec to heimdall-bootimg

Merged Imported Administrator requested to merge i9003-armv7 into master
All threads resolved!

I noticed that the Samsung i9003 is actually a heimdall-bootimg device. But at the same time, the kernel is assembled as if it is isorec. I built the kernel in a standard way and did not see a difference in the size of vmlinuz nor in the behavior of its work.

  • Changed armhf to armv7
Edited by Administrator

Merge request reports

Approval is optional

Merged by AdministratorAdministrator 4 years ago (Jun 2, 2020 11:49am UTC)

Merge details

  • Changes merged into master with a20c2697.
  • Deleted the source branch.

Pipeline #195006 passed

Pipeline passed for a20c2697 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Михалыч on 2020-05-31T03:52:38

  • Administrator resolved all threads · Imported

    resolved all threads

    By Alexey Min on 2020-05-31T07:02:01

  • Administrator approved this merge request · Imported

    approved this merge request

    By Alexey Min on 2020-05-31T07:02:14

  • Administrator added category::device type::feature + 1 deleted label · Imported

    added category::device type::feature + 1 deleted label

  • Administrator approved this merge request · Imported

    approved this merge request

    By Bart Ribbers on 2020-05-31T08:53:57

  • Author Owner

    We can't merge this @LibrePhone. Please check the checkbox in your MR to allow us to push to your branch, and while you're at it also squash your commits into 1 and reword it to the title of this MR.

    By Bart Ribbers on 2020-05-31T08:58:18

  • Administrator added 3 commits · Imported

    added 3 commits

    • bb05822b - 1 commit from branch postmarketOS:master
    • ed68e91f - Change armhf to armv7 and heimdall-isorec to heimdall-bootimg
    • 09e73326 - fix version

    Compare with previous version

    By Михалыч on 2020-06-01T04:45:08

  • Administrator added 1 commit · Imported

    added 1 commit

    • 64c6e9ad - Change armhf to armv7 and heimdall-isorec to heimdall-bootimg

    Compare with previous version

    By Михалыч on 2020-06-01T05:11:32

  • Administrator approved this merge request · Imported

    approved this merge request

    By Alexey Min on 2020-06-01T05:21:59

  • Administrator approved this merge request · Imported

    approved this merge request

    By Antoine Fontaine on 2020-06-02T11:02:12

  • Author Owner

    I can't test this works (I've built locally), but from a packaging point of view it looks good to me.

    By Antoine Fontaine on 2020-06-02T11:02:30

    Edited by Administrator
  • Administrator added 6 commits · Imported

    added 6 commits

    • 64c6e9ad...80f332c9 - 5 commits from branch postmarketOS:master
    • a20c2697 - samsung-i9003: change to armv7, remove isorec code (MR 1277)

    Compare with previous version

    By Oliver Smith on 2020-06-02T11:44:08

  • Author Owner

    Thanks, @LibrePhone!

    @PureTryOut wrote:

    Please check the checkbox in your MR to allow us to push to your branch

    We have a CI check for that, and I've verified that it is still working. What happened here is, that the project was renamed, it seems.

    @afontain: pushing worked for me, after mrhlpr checkout 1277. Note that I'm also using git config push.default upstream for pmaports.git.

    (There's also mrhlpr -n to use no cache, might be needed as well if this MR was checked out earlier already with mrhlpr.)

    $ git push --force
    ...
    Enumerating objects: 60, done.
    Counting objects: 100% (60/60), done.
    Delta compression using up to 2 threads
    Compressing objects: 100% (52/52), done.
    Writing objects: 100% (52/52), 86.49 KiB | 3.93 MiB/s, done.
    Total 52 (delta 27), reused 0 (delta 0)
    remote: 
    remote: View merge request for i9003-armv7:
    remote:   https://gitlab.postmarketos.org/postmarketos/pmaports/-/merge_requests/1277
    remote: 
    remote: Project 'LibrePhone/pmaports' was moved to 'LibrePhone/pmaports123'.
    remote: 
    remote: Please update your Git remote:
    remote: 
    remote:   git remote set-url origin git@gitlab.com:LibrePhone/pmaports123.git
    remote: 
    To gitlab.com:LibrePhone/pmaports.git
     + 64c6e9ada...a20c2697b mrhlpr/1277 -> i9003-armv7 (forced update)

    By Oliver Smith on 2020-06-02T11:48:54

    Edited by Administrator
  • Administrator merged · Imported

    merged

    By Oliver Smith on 2020-06-02T11:49:19

  • Administrator mentioned in issue #599 · Imported

    mentioned in issue #599

    By Antoine Fontaine on 2020-06-02T12:06:20

  • Please register or sign in to reply
    Loading