maemo/libhildon: remove inline from function to enable compiling hildon-desktop on armv7

Do note that this is not finished yet. Compiling for most packages works fine, but it breaks on maemo/hildon-desktop (only on armv7) with the following error:

/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_clip_to_alloc'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_draw_hue_bar_dimmed'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_draw_sv_plane'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_h2rgb'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_draw_hue_bar'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_draw_sv_plane_dimmed'
/usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../../armv7-alpine-linux-musleabihf/bin/ld: /usr/lib/gcc/armv7-alpine-linux-musleabihf/8.2.0/../../../libhildon-1.so: undefined reference to `inline_limited_expose'
collect2: error: ld returned 1 exit status

I've already mentioned this in #maemo-leste, but maybe someone else knows what's wrong.

I decided to go for $arch = "all !x86" instead of $arch = "x86_64 armhf aarch64", as I understood the packages are only broken on x86. Rather than adding all architectures that do work, this makes sure it can be compiled on all architectures except for x86. Also, I believe the $pkgrel doesn't have to be increased as the only thing changed in this packaging is making armv7 compiling possible, which is useless for the other architectures.

added 1 commit

• 7d90ca51 - hildon/* & weston: enable compiling for armv7

Compare with previous version

By Bart Ribbers on 2019-01-04T14:11:56

added 1 commit

• f4e0d9da - hildon/* & weston: enable compiling for armv7

Compare with previous version

By Bart Ribbers on 2019-01-04T14:13:08

mentioned in issue #160 (closed)

By Oliver Smith on 2019-01-04T20:33:20

mentioned in merge request !131 (merged)

By Grant Miller on 2019-01-04T20:59:44

mentioned in merge request !126 (merged)

By Bart Ribbers on 2019-01-04T23:38:11

added 3 commits

• f4e0d9da...6225dfa5 - 2 commits from branch master
• c2fed5c2 - hildon/* & weston: enable compiling for armv7

Compare with previous version

By Bart Ribbers on 2019-01-05T00:14:50

Yep, inline functions shouldn't be included in the final binary... Easiest workaround is removing the "inline" keyword for these functions.

By Luca Weiss on 2019-01-05T12:24:04

I somehow ran in to the libhildon-1.so: undefined reference error while I was messing around with building hildon-desktop for x86 but it went away after I zapped everything. I'm not sure if that helps with your debugging.

By Grant Miller on 2019-01-06T00:49:42

added 13 commits

• c2fed5c2...b21caaee - 12 commits from branch master
• 39e3ce6b - hildon/* & weston: enable compiling for armv7

Compare with previous version

By Bart Ribbers on 2019-01-09T11:00:47

@z3ntu The problem is that those functions are no where to be found in the source of that package. Zapping everything doesn't work either, I did that multiple times without luck.

By Bart Ribbers on 2019-01-09T11:42:58

Without looking at the sources, this might be caused because the executable is linked against a static library (i.e. just included in the binary) that includes those symbols. Maybe check that.

By Luca Weiss on 2019-01-09T12:12:39

added 1 commit

• 177e489b - maemo/libhildon: remove inline from some functions to make hildon-desktop compile on armv7

Compare with previous version

By Bart Ribbers on 2019-01-09T19:04:33

unmarked as a Work In Progress

By Bart Ribbers on 2019-01-09T19:07:01

changed title from {-WIP: hildon/ & weston: enable compiling for-} armv7* to maemo/libhildon: remove inline from function to enable compiling hildon-desktop on armv7

By Bart Ribbers on 2019-01-09T19:07:01

changed the description

By Bart Ribbers on 2019-01-09T19:07:01

The problem was actually in libhildon. I made the functions non-inline, and now everything compiles correctly on armv7. Do note that lightdm for armv7 hasn't been uploaded to the Alpine repos yet for some reason, so right now postmarketos-ui-hildon both can't be build or installed. It should be good for merging now though.

By Bart Ribbers on 2019-01-09T19:08:55

LightDM for armv7 has been uploaded to the Alpine repos, this should be usable now.

By Bart Ribbers on 2019-01-10T11:54:13

mentioned in commit c7643bc2

By Bart Ribbers on 2019-01-10T21:50:52

added 9 commits

• 177e489b...ab9d05ee - 8 commits from branch master
• c7643bc2 - maemo/libhildon: fix hildon-desktop armv7 build (!130 (merged))

Compare with previous version

By Oliver Smith on 2019-01-10T21:50:52

mentioned in commit 2c08e209

By Bart Ribbers on 2019-01-10T21:57:34

mentioned in commit aaae2716

By Bart Ribbers on 2019-01-10T21:57:34

added 2 commits

• aaae2716 - hildon-theme-alpha: fix warnings in APKBUILD (!130 (merged))
• 2c08e209 - maemo/libhildon: fix hildon-desktop armv7 build (!130 (merged))

Compare with previous version

By Oliver Smith on 2019-01-10T21:57:34

approved this merge request

By Oliver Smith on 2019-01-10T21:57:48

I've split the hildon-theme-alpha and arch-bin-masquerade changes into own commits, so it matches the commit messages. (In general, I'm trying to do one logical change in one commit, where it makes sense.)

Changes look good. Thanks @PureTryOut!

By Oliver Smith on 2019-01-10T21:59:38

enabled an automatic merge when the pipeline for 2c08e209 succeeds

By Oliver Smith on 2019-01-10T21:59:57

merged

By Oliver Smith on 2019-01-10T22:01:24

mentioned in commit d560188e

By Bart Ribbers on 2019-02-14T19:42:54

mentioned in commit e40d8d79

By Bart Ribbers on 2019-02-14T19:42:54