hildon, weston: Fix for 32 bit x86

Oh, didn't realize you were working on this. Does libhildondesktop compile for you without the patch that I added in my PR? For me it's broken on all architectures without that patch, and I'm not entirely sure how we got it to compile in the first place.

I guess it makes sense to first merge this request, then rebase !130 (merged) to the latest master and focus purely on the armv7 compilation failures.

I personally would like to wait with merging for the responses to your PR to hildon-desktop, see if it gets accepted there.

By Bart Ribbers on 2019-01-04T23:25:36

Does libhildondesktop compile for you without the patch that I added in my PR?

Apparently not. I didn't test all the packages, but did successfully compile the following packages for x86:

postmarketos-demos
weston
postmarketos-ui-weston
hildon-desktop
postmarketos-ui-hildon
gtk+2.0-maemo

Would you like to push your libhildondesktop patch to this branch? Then I can try building with --mirror-pmOS=""

By Grant Miller on 2019-01-04T23:44:54

I wrote a script to build all affected packages (which I really should have done in the first place)

#!/bin/bash

set -e

failures=""

for apkbuild in $(git diff --name-only master | grep APKBUILD); do
	package=$(basename $(dirname $apkbuild))
	pmbootstrap build --strict --force --arch x86 $package \
		|| failures="$failures $package"
done

echo "Failures: $failures"

In addition to libhildondesktop, hildon-thumbnail also fails for all arches with the following error:

make[4]: *** No rule to make target '../daemon/libshared.la', needed by 'hildon-thumbnailerd'. Stop.

By Grant Miller on 2019-01-05T18:11:41

added 1 commit

4d515317 - maemo/hildon-desktop: Update to 2.2.157.11

Compare with previous version

By Grant Miller on 2019-01-06T00:09:03

added 1 commit

b20962dc - maemo/libhildondesktop: Fix compilation

Compare with previous version

By Grant Miller on 2019-01-06T00:34:14

Progress update:

My PR for hildon-desktop was accepted and they tagged a new release
I added the patch for libhildondesktop
No progress on hildon-thumbnail and I'm not very familiar with automake. I will ask about it on the maemo-leste IRC channel.

By Grant Miller on 2019-01-06T00:46:05

mentioned in issue #160 (closed)

By Oliver Smith on 2019-01-06T11:00:00

@GrantM11235

We had a lot of packages that were disabled for x86 because alpine's aport of libunwind didn't support x86. They fixed that about a week ago.

Great news \o/

@PureTryOut wrote:

I guess it makes sense to first merge this request, then rebase !130 (merged) to the latest master and focus purely on the armv7 compilation failures.

Sounds good.

Thanks for your work on this, guys!

By Oliver Smith on 2019-01-06T11:08:44

I created #164 (closed) to track the hildon-thumbnail issue. IMO, this can be merged as-is.

By Grant Miller on 2019-01-08T05:42:39

Btw to build all Hildon packages, you can also just force build postmarketos-ui-hildon. Way easier than writing a script

By Bart Ribbers on 2019-01-08T17:29:49

changed title from hildon: Fix for 32 bit x86 to hildon, weston: Fix for 32 bit x86

By Grant Miller on 2019-01-08T17:50:12

changed the description

By Grant Miller on 2019-01-08T17:50:12

mentioned in merge request !138 (merged)

By Grant Miller on 2019-01-08T18:19:34

added 11 commits

b20962dc...66121592 - 3 commits from branch postmarketOS:master
13c73cba - Revert "main/postmarketos-demos, -ui-weston: disable x86" (!131 (merged))
7194f63d - Revert "maemo/hildon-desktop: disable x86" (!131 (merged))
a03b2172 - Revert "hildon: disable building x86 for all packages" (!131 (merged))
cb200a36 - maemo/hildon-desktop: Remove obsolete "patch" (!131 (merged))
038ecb45 - temp/weston: Re-enable x86 (!131 (merged))
d6963a06 - maemo/hildon-desktop: Fix compilation for 32 bit x86 (!131 (merged))
386354e6 - maemo/hildon-desktop: Update to 2.2.157.11 (!131 (merged))
ef59cc8a - maemo/libhildondesktop: Fix compilation (!131 (merged))

Compare with previous version

By Oliver Smith on 2019-01-09T06:42:04

approved this merge request

By Oliver Smith on 2019-01-09T06:43:31

Changes look good, I've verified that everything builds.

It would be nice if we could skip the "too many packages have changed" sanity check, created #165 (closed) for that.

Thanks a lot @GrantM11235!

By Oliver Smith on 2019-01-09T06:44:42

merged

By Oliver Smith on 2019-01-09T06:45:22

mentioned in commit d6963a06

By Grant Miller on 2019-01-18T22:37:57

mentioned in commit 386354e6

By Grant Miller on 2019-01-18T22:37:57

mentioned in commit 038ecb45

By Grant Miller on 2019-01-18T22:37:57

mentioned in commit cb200a36

By Grant Miller on 2019-01-18T22:37:57

mentioned in commit a03b2172

By Grant Miller on 2019-01-18T22:37:57

mentioned in commit ef59cc8a

By Grant Miller on 2019-01-18T22:37:58

mentioned in commit 7194f63d

By Grant Miller on 2019-01-18T22:37:58

mentioned in commit 13c73cba

By Grant Miller on 2019-01-18T22:37:59

mentioned in commit 47b5043e