main/postmarketos-android-recovery-installer: Fix No OS warning

Tested on sony-amami with TWRP 3.0.2

mentioned in issue pmbootstrap#1451 (closed)

By Attila Szollosi on 2019-01-22T23:25:54

changed the description

By Attila Szollosi on 2019-01-22T23:30:18

Tested on lg-mako, TWRP 3.1.1-0. Without the patch, I get the "No OS installed! Are you sure you wish to reboot?" message as expected. With the patch, that does not happen anymore (as expected).

What follows is logical as I've already seen it when installing Android ROMs with TWRP, but still I was surprised - it tried to drive-by install "the offical TWRP" app. The good news is, that even if one does the suggested "swipe to install twrp app" move, it seems like nothing happens and postmarketOS boots just as expected. The same happens when touching the "do not install" button.

I wonder if we can disable it from asking to install the TWRP app (maybe fake that it is already installed too?)

Thanks a lot for the MR @ata2001!

By Oliver Smith on 2019-01-25T07:17:50

added 7 commits

• 17a7a7c0 - code style (#include)
• 45546993 - Exit if file doesn't exist
• 449881e6 - Declare and assign value on the same line
• f4d96d2a - Add comment explaining the fallback method for closing file descriptors
• 167a80bd - Disable TWRP app prompt
• c1d44688 - minor style change
• 0b715f1a - Update checksum

Compare with previous version

By Attila Szollosi on 2019-01-26T12:56:30

added 20 commits

• 0b715f1a...eb30c690 - 19 commits from branch postmarketOS:master
• b24a2a4c - recovery zip: fix "No OS installed" warning (!169 (merged))

Compare with previous version

By Oliver Smith on 2019-01-28T08:52:40

approved this merge request

By Oliver Smith on 2019-01-28T08:53:02

resolved all discussions

By Oliver Smith on 2019-01-28T08:53:11

Wow, you've even disabled the TWRP app prompt. Tested and working - great work @ata2001 \o/

By Oliver Smith on 2019-01-28T08:53:49

enabled an automatic merge when the pipeline for b24a2a4c succeeds

By Oliver Smith on 2019-01-28T08:54:03

merged

By Oliver Smith on 2019-01-28T08:54:06

mentioned in commit b24a2a4c

By Attila Szollosi on 2019-02-11T21:36:41

mentioned in commit 18673997

By Attila Szollosi on 2019-02-14T19:42:53