Skip to content
Snippets Groups Projects

main/blobtools: Allow blob signing

Merged Imported Administrator requested to merge feature/blobtools_signing into master
All threads resolved!

Certain recent Asus Tegra SoC based devices (tf201, tf300, tf700) only accept signed blobs, this was implemented upstream but seems that some lines got deleted so it wasn't being signed which was fine for devices (Asus tf101) that didn't require it.

To reuse the existing setup I added a patch for blobtools that let us enable singing via optional flag, this same flag is only enabled when device has deviceinfo_bootimg_blobpack="sign" existing devices (tf101) use deviceinfo_bootimg_blobpack="true" which shouldn't be affected by these changes.

After this MR there is plans to send MR for initial asus-tf201 bringup.

Edited by Administrator

Merge request reports

Approval is optional

Merged by AdministratorAdministrator 4 years ago (Dec 28, 2020 2:07pm UTC)

Merge details

  • Changes merged into with 02c6181e.
  • Deleted the source branch.

Pipeline #196475 passed

Pipeline passed for 02c6181e on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
  • Administrator
  • Administrator added 1 deleted label · Imported

    added 1 deleted label

  • Administrator added 1 commit · Imported

    added 1 commit

    • 3a124d89 - main/mkinitfs: Pass signing flag to blobpack

    Compare with previous version

    By Ion A on 2020-12-11T14:08:04

  • Administrator added 1 commit · Imported

    added 1 commit

    • 6990b5e0 - main/mkinitfs: Pass signing flag to blobpack

    Compare with previous version

    By Ion A on 2020-12-11T14:22:11

  • Administrator resolved all threads · Imported

    resolved all threads

    By Ion A on 2020-12-17T08:39:03

  • Author Owner

    Thanks for the update, @IonAgorria! Also sorry that it took me some time to get back to this.

    I've imported your repo here: https://gitlab.com/postmarketOS/asus-transformer-blobtools

    And tagged a release: https://gitlab.com/postmarketOS/asus-transformer-blobtools/-/tags/1.1.0

    (1.0.0 is the one from github)

    So now I suggest to update the blobtools package:

    • use this 1.1.0 version
    • rename it to asus-transformer-blobtools

    By Oliver Smith on 2020-12-17T11:55:02

  • Administrator added 27 commits · Imported

    added 27 commits

    • 6990b5e0...e07b405b - 25 commits from branch postmarketOS:master
    • adbe71ac - main/mkinitfs: Pass signing flag to blobpack
    • 099e9252 - main/asus-transformer-blobtools: Add blob signing

    Compare with previous version

    By Ion A on 2020-12-17T17:31:25

  • Administrator added 1 commit · Imported

    added 1 commit

    • cd106316 - main/asus-transformer-blobtools: Add blob signing

    Compare with previous version

    By Ion A on 2020-12-17T18:12:36

  • Author Owner

    Awesome, I made the change of package name and APKBUILD modifications in same commit but if it's preferred to be separate commits I can change it.

    By Ion A on 2020-12-18T17:54:01

  • Administrator
    • Author Owner
      Resolved by Administrator

      Awesome, I made the change of package name and APKBUILD modifications in same commit but if it's preferred to be separate commits I can change it.

      That's fine. Let's get this merged soon. I'm just wondering about that new mv line.

      By Oliver Smith on 2020-12-20T16:15:42

      Edited by Ghost User
  • Administrator added 1 commit · Imported

    added 1 commit

    • 30ebb6f9 - device/asus-tf101: Update blobtools to new name

    Compare with previous version

    By Ion A on 2020-12-22T12:31:39

  • Administrator added 1 commit · Imported

    added 1 commit

    • 48749f86 - device-asus-tf101: Update blobtools to new name

    Compare with previous version

    By Ion A on 2020-12-22T13:27:52

  • Administrator resolved all threads · Imported

    resolved all threads

    By Ion A on 2020-12-26T20:33:20

  • Administrator approved this merge request · Imported

    approved this merge request

    By Alexey Min on 2020-12-28T01:35:37

  • Administrator added 30 commits · Imported

    added 30 commits

    • 48749f86...0141b194 - 27 commits from branch postmarketOS:master
    • b57f20e5 - main/mkinitfs: Pass signing flag to blobpack
    • 4391d998 - main/asus-transformer-blobtools: Add blob signing
    • 541f714f - device-asus-tf101: Update blobtools to new name

    Compare with previous version

    By Ion A on 2020-12-28T12:32:27

  • Administrator added 3 commits · Imported

    added 3 commits

    • 485bfdcd - main/mkinitfs: Pass signing flag to blobpack
    • 6ac7b838 - main/asus-transformer-blobtools: Add blob signing
    • e7ea5d55 - device-asus-tf101: Update blobtools to new name

    Compare with previous version

    By Ion A on 2020-12-28T12:43:02

  • Author Owner

    Thanks for the update, @IonAgorria!

    I'll squash the two patches that modify the blobtools package into one, fix the checksums and then I'll merge it.

    EDIT: oh, no need to squash. I didn't read the commit messages properly.

    By Oliver Smith on 2020-12-28T13:59:41

    Edited by Administrator
  • Administrator added 3 commits · Imported

    added 3 commits

    • 4351a5bc - main/mkinitfs: Pass signing flag to blobpack (MR 1803)
    • e4a99772 - main/asus-transformer-blobtools: Add blob signing (MR 1803)
    • 02c6181e - device-asus-tf101: Update blobtools to new name (MR 1803)

    Compare with previous version

    By Oliver Smith on 2020-12-28T14:04:29

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2020-12-28T14:04:40

  • Administrator enabled an automatic merge when the pipeline for 02c6181e succeeds · Imported

    enabled an automatic merge when the pipeline for 02c6181e succeeds

    By Oliver Smith on 2020-12-28T14:05:04

  • Administrator merged · Imported

    merged

  • Please register or sign in to reply
    Loading