cross: add crossdirect package (pmbootstrap#1731)
Merge request reports
Activity
added 1 commit
- ccd37a09 - cross: add crossdirect package (pmbootstrap#1731 (closed))
By Zhuowei Zhang on 2019-02-16T05:20:23
mentioned in merge request pmbootstrap!1758 (merged)
By Zhuowei Zhang on 2019-02-20T02:17:16
Initial code review done (without running the code yet).
I like how you're mounting the native chroot as
/nativebtw, that makes the resulting code paths short and easy to understand. Also you have already taken care of clang support - wow!So I did not try the code yet, but I'll do after the next revision. If everything runs as expected, then this is such an incredible improvement for pmbootstrap that we could even write a short blog post about it (assuming that somebody finds time for it
Thanks a lot @zhuowei \o/
By Oliver Smith on 2019-02-27T10:47:57
-
@ollieparanoid Thank you so much for the comments!
Also you have already taken care of clang support - wow!
No, this doesn't work automatically with Clang: unlike GCC, Clang isn't supported by ccache. I only add the crossdirect wrappers to the ccache path, so APKBUILDs can't automatically find our clang wrapper.
Since we only have one package that uses clang (mir), I just manually modified that APKBUILD to point it to the wrapper during testing.
this is such an incredible improvement for pmbootstrap that we could even write a short blog post about it
I don't expect this to give an improvement significant enough for a separate blog post ("Building packages is now as fast as before we added SSH to distcc" doesn't sound that interesting...) I would need to benchmark how much time this saves for a package though.
I will address your comments, and then compare building a large package (maybe one of the qt packages?) against the old distcc and the new distccd-ssh implementation. Unfortunately, I'll be busy this month, so might not get to it soon - but I'll work on it when I can.
By Zhuowei Zhang on 2019-02-27T20:29:55
-
I don't expect this to give an improvement significant enough for a separate blog post ("Building packages is now as fast as before we added SSH to distcc" doesn't sound that interesting...) I would need to benchmark how much time this saves for a package though.
Well, you had explained earlier that the linking step is also done with the native binaries - so I would expect it to be at least a little faster than the old distcc (without ssh) setup. But you are right, let's wait for benchmarks instead of making assumptions.
I will address your comments, and then compare building a large package (maybe one of the qt packages?) against the old distcc and the new distccd-ssh implementation. Unfortunately, I'll be busy this month, so might not get to it soon - but I'll work on it when I can.
Thank you, highly appreciated!
By Oliver Smith on 2019-02-28T12:25:10
mentioned in issue #192 (closed)
By Oliver Smith on 2019-03-05T06:47:37
added 110 commits
-
ccd37a09...0d966c7a - 108 commits from branch
postmarketOS:master - 68c1d5d2 - cross: add crossdirect package (!222 (merged))
- b6ec8550 - pmaports.cfg: bump version to 3 (!222 (merged))
By Oliver Smith on 2019-03-23T00:10:47
-
ccd37a09...0d966c7a - 108 commits from branch
mentioned in commit b6ec8550
By Oliver Smith on 2019-03-29T13:32:36
added category::crossdirect label
