Skip to content
Snippets Groups Projects

Split i9300 into separate packages and use codenames, and set up WiFi properly on mainline

Merged Imported Administrator requested to merge m-split into master

m0 and m3 are the "real" codenames for i9300 and i9305, respectively. Furthermore, it doesn't make much sense to keep these two in the same device package (I can only maintain m0 since I don't own an m3), and even less the downstream kernel since the gpu_accelerated property is shared between mainline and downstream but should have a different value for downstream than mainline.

Anyway, as mentioned, I don't have an m3! If you have one, testing is very welcome. I haven't tested this on my m0 yet, thus it's a draft.

Added to renamed devices: https://wiki.postmarketos.org/wiki/Renamed_Devices

Part-of https://gitlab.com/postmarketOS/pmaports/-/issues/35
Closes https://gitlab.com/postmarketOS/pmaports/-/issues/1017

Edited by Administrator

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
    • Author Owner
      Resolved by Administrator

      sha512 sum for unmaintained deviceinfo seem to need to be updated. The unmaintained kernel then also fails to flash with:

      $ pmbootstrap flasher flash_kernel
      [20:41:02] (rootfs_samsung-m0-downstream) mkinitfs samsung-m0
      [20:41:04] ERROR: Could not find aport for package: linux-samsung-m0
      [20:41:04] See also: <https://postmarketos.org/troubleshooting>
      Run 'pmbootstrap log' for details.

      But this looks more like an issue with postmarketos-mkinitfs, APKBUILD and deviceinfo looks good to me

      Flavor needs to be changed to _flavor="samsung-m0-downstream", and the config renamed accordingly

      By Henrik Grimler on 2021-09-27T07:00:16

      Edited by Administrator
  • Administrator added 1 commit · Imported

    added 1 commit

    • 4c672552 - samsung-m0-downstream: new device

    Compare with previous version

    By Newbyte on 2021-09-27T06:56:04

  • Administrator mentioned in merge request !2557 (closed) · Imported

    mentioned in merge request !2557 (closed)

    By Luca Weiss on 2021-09-27T09:19:36

  • Administrator added 4 commits · Imported

    added 4 commits

    • 4faa744c - samsung-m0: new device
    • ee4139b4 - samsung-m3: new device
    • c68ecafb - firmware-samsung-m0: rename from i9300 and split
    • c0d30ded - samsung-m0-downstream: new device

    Compare with previous version

    By Newbyte on 2021-09-27T21:02:17

  • Administrator added 31 commits · Imported

    added 31 commits

    Compare with previous version

    By Newbyte on 2021-09-27T21:02:40

  • Administrator marked this merge request as ready · Imported

    marked this merge request as ready

    By Newbyte on 2021-09-27T21:02:43

  • Administrator resolved all threads · Imported

    resolved all threads

    By Newbyte on 2021-09-27T21:03:09

  • Author Owner

    I've not been able to test this on samsung-m3 as I don't own one, but it works as expected on samsung-m0 — and removes the need to manually set up WiFi firmware. If you're reading this and you own samsung-m3 (Galaxy S III LTE), testing is very welcome! And thanks to Grimler for fixing the firmware package for me.

    By Newbyte on 2021-09-27T21:04:41

  • Author Owner

    I'm not sure what to do about the wiki failure though, or what to do with the package versions. Should I keep them what they are now? Restart from 1?

    I don't think it makes sense to replace the old packages since they are split now, and I can't detect which variant users have, so there is a risk they will get packages for the wrong phone. Plus, the devices are in testing, so I don't think it matters.

    By Newbyte on 2021-09-27T21:07:36

    Edited by Administrator
  • Administrator added 2 commits · Imported

    added 2 commits

    • bfe82043 - firmware-samsung-m0: rename from i9300 and split
    • ff41bd19 - samsung-m0-downstream: new device

    Compare with previous version

    By Newbyte on 2021-09-28T10:04:10

  • Administrator added 6 commits · Imported

    added 6 commits

    • f9fae7bf - 1 commit from branch postmarketOS:master
    • 49ebad47 - samsung-i9300: drop
    • eec60080 - samsung-m0: new device
    • eb8eb4bf - samsung-m3: new device
    • 73420b88 - firmware-samsung-m0: rename from i9300 and split
    • 210b7a68 - samsung-m0-downstream: new device

    Compare with previous version

    By Newbyte on 2021-09-28T10:15:53

  • Administrator added 5 commits · Imported

    added 5 commits

    • 37b7e5d2 - samsung-i9300: drop
    • 34768e2e - samsung-m0: new device
    • c757a219 - samsung-m3: new device
    • 5d825a81 - firmware-samsung-m0: rename from i9300 and split
    • 59ecc7a0 - samsung-m0-downstream: new device

    Compare with previous version

    By Newbyte on 2021-09-28T10:20:50

  • Administrator added 6 commits · Imported

    added 6 commits

    • f9fae7bf - 1 commit from branch postmarketOS:master
    • 473b8935 - samsung-i9300: drop
    • e15fc709 - samsung-m0: new device
    • b34f4fd9 - samsung-m3: new device
    • ae1e614f - firmware-samsung-m0: rename from i9300 and split
    • ee6452cc - samsung-m0-downstream: new device

    Compare with previous version

    By Newbyte on 2021-09-28T10:23:11

  • Administrator added 1 commit · Imported

    added 1 commit

    • c375d79f - samsung-m0-downstream: new device

    Compare with previous version

    By Newbyte on 2021-09-28T10:50:53

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading