temp/p-wlroots: Add wlroots with patch for pvr

Added patched wlroots for PowerVR GPU. Still on 0.12 as I'm testing it on Phosh and that still uses 0.12.

marked this merge request as draft

By Mighty on 2021-10-05T05:26:27

Why is aports lint not happy

By Mighty on 2021-10-07T06:33:28

Any chance of these patches being upstreamed to wlroots?

By Bart Ribbers on 2021-10-07T06:39:22

added 7 commits

• cc8eaba3...03ddd742 - 6 commits from branch postmarketOS:master
• ac35b417 - temp/p-wlroots: Add wlroots with patch for pvr

Compare with previous version

By Mighty on 2021-10-09T13:52:09

marked this merge request as ready

By Mighty on 2021-10-09T13:56:09

The wlroots 0.12 package in alpine is called "wlroots0.12".

If we should merge this, we must make sure that apk/pmbootstrap don't install this by accident instead of wlroots0.12 from Alpine.

The cleanest way I know how to do this, is with:

replaces="wlroots0.12"
options="!tracedeps"

https://wiki.alpinelinux.org/wiki/APKBUILD_Reference#replaces

• replaces: then it can be installed at the same time as "wlroots0.12" and will replace its files.
• !tracedeps: so abuild doesn't automatically add metadata that it provides the wlroots 0.12 so library

By Oliver Smith on 2021-10-10T13:29:43

I really hope merging this doesn't reintroduce the issues we had with trying to 'replace' mesa/mesa-dev a while back. I'm not entirely sure how to safeguard against that happening again if we decide to merge this patch.

By clayton craft on 2021-10-23T21:30:01

So should we drop it then? I dont see any other option

By Mighty on 2021-10-25T09:29:35

No, now with proper "provides" and "replaces" we should be able to get this working.. and avoid past problems with mesa-git

By Alexey Min on 2021-10-25T10:11:54

changed this line in version 3 of the diff

By Mighty on 2021-10-29T16:48:09

I hope its better now...

By Mighty on 2021-10-29T16:48:23

This will replace wlroots0.12, but what about the normal wlroots then? We'll have to make two packages p-wlroots0.12 and p-wlroots?

By Mighty on 2021-10-31T06:35:21

Hi @MightyM17,

I'm a bit hesitant to merge such hacks in general, so I'm wondering:

• on which device are you using this?
• do you plan to maintain this package in the future?

By Oliver Smith on 2021-10-10T15:43:04

I understand the hesitation, but there is no other option :( Well im using it on samsung-espresso3g and i dont mind maintaining it, theres also an updated tree by tmlind https://github.com/tmlind/wlroots/

By Mighty on 2021-10-10T15:43:04

added 1 commit

• 10ffe7f1 - temp/p-wlroots: Add wlroots with patch for pvr

Compare with previous version

By Mighty on 2021-10-29T16:48:10

What's the link error now?

By Mighty on 2021-10-29T17:16:22

added 91 commits

• 10ffe7f1...54b2ff69 - 90 commits from branch postmarketOS:master
• 58c17b46 - temp/p-wlroots: Add wlroots with patch for pvr

Compare with previous version

By Mighty on 2021-10-30T06:24:40

Hey @MightyM17! Sorry for not getting back to you on this sooner.

We spent some time discussing in the team whether we want to merge this or not in the last meeting, and voted against it since it does create some extra maintenance effort for us, even if you maintain it (just the amount of packages, what if this package happens to break the builders and you're not around to fix it? we had the exact same situation with libhybris and then we finally decided to remove that too).

However, there is a way forward other than merging this into pmaports:

• create a dir prefixed with custom- in your pmaports, e.g. custom-pvr. The gitignore will ignore it then.
• create a git repository inside that directory and upload it somewhere (e.g. own namespace on gitlab or sourcehut)
• build the package locally and host your own repository (either over lan, or put the repository somewhere on the internet). Add the repository to your /etc/apk/repositories as described in the wiki
• Now you can use the custom pvr packages on your device

By Oliver Smith on 2021-11-01T15:21:27

closed

mentioned in issue #1316 (closed)

By mirh on 2022-03-27T12:38:07