Skip to content
Snippets Groups Projects

hybris/*: enable building for armv7

Merged Imported Administrator requested to merge upstreaming into master
All threads resolved!

Since some devices have recently switched from armhf to armv7 arch, we need to be able to build packages for armv7, too.

Examples:

Edited by Administrator

Merge request reports

Approval is optional

Merged by AdministratorAdministrator 6 years ago (Apr 5, 2019 10:31pm UTC)

Merge details

  • Changes merged into master with fb784b62.
  • Deleted the source branch.

Pipeline #191045 passed

Pipeline passed for fb784b62 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator added 1 commit · Imported

    added 1 commit

    • f7c4413c - hybris/libhybris: enable building for armv7

    Compare with previous version

    By Alexey Min on 2019-04-03T13:41:17

  • Administrator changed title from hybris/*: enable building for armv7 arch to hybris/libhybris: enable building for armv7 arch · Imported

    changed title from hybris/*: enable building for armv7 arch to hybris/libhybris: enable building for armv7 arch

    By Alexey Min on 2019-04-03T13:41:32

  • Administrator changed the description · Imported

    changed the description

    By Alexey Min on 2019-04-03T13:41:32

  • Administrator added 1 commit · Imported

    added 1 commit

    • 8f3540dd - hybris/libhybris: enable building for armv7

    Compare with previous version

    By Alexey Min on 2019-04-03T13:42:35

  • Administrator added 1 commit · Imported

    added 1 commit

    • daedc584 - hybris/libhybris: enable building for armv7

    Compare with previous version

    By Alexey Min on 2019-04-03T13:43:54

  • Administrator added 1 commit · Imported

    added 1 commit

    • 9ae4209a - hybris/libhybris: VERBOSE build (to test CI)

    Compare with previous version

    By Alexey Min on 2019-04-03T14:33:03

  • Administrator marked as a Work In Progress · Imported

    marked as a Work In Progress

    By Alexey Min on 2019-04-03T17:04:22

  • Administrator added 1 commit · Imported

    added 1 commit

    • 88dacbf9 - hybris/libhybris: bring arches list to initial state just to test CI

    Compare with previous version

    By Alexey Min on 2019-04-03T17:26:57

  • Administrator added 5 commits · Imported

    added 5 commits

    Compare with previous version

    By Alexey Min on 2019-04-04T07:27:16

  • Administrator unmarked as a Work In Progress · Imported

    unmarked as a Work In Progress

    By Alexey Min on 2019-04-04T07:29:30

  • Administrator changed title from WIP: hybris/libhybris: enable building for armv7 arch to hybris/*: enable building for armv7 · Imported

    changed title from WIP: hybris/libhybris: enable building for armv7 arch to hybris/*: enable building for armv7

    By Alexey Min on 2019-04-04T07:29:30

  • Author Owner

    I see 2 problems:

    • libhybris takes too long to build?
    • incorrect options for busybox ps?
    (000168) [07:39:10] Process did not write any output for 300 seconds. Killing it.
    (000168) [07:39:10] NOTE: The timeout can be increased with 'pmbootstrap -t'.
    ps: unrecognized option: noheaders
    BusyBox v1.28.4 (2018-12-31 18:05:13 UTC) multi-call binary.
    
    Usage: ps [-o COL1,COL2=HEADER]
    
    Show list of processes
    
    	-o COL1,COL2=HEADER	Select columns for display
    (000168) [07:39:10] ERROR: Command '['ps', '-e', '-o', 'pid=,ppid=', '--noheaders']' returned non-zero exit status 1.
    (000168) [07:39:10] See also: <https://postmarketos.org/troubleshooting>

    Need help with building this on CI. It builds fine locally for all armhf, armv7 and aarch64...

    By Alexey Min on 2019-04-04T08:46:43

  • Author Owner

    nvm, I think I've found the source of failure in pmbootstrap... Commit https://gitlab.com/postmarketOS/pmbootstrap/commit/1fffe83df384d2030c2eaea077c34fecdd984f1e broke it, I was compiling locally with "old" pmbootstrap (at commit a7985399 (tag: 1.5.1)). After updating pmbootstrap to master I got build failure locally too.

    I will now verfy and bisect failing commit to be exactly sure

    x 794e0856 (HEAD -> master, origin/master, origin/HEAD) crossdirect: use native ccache, fix armhf error (!1773)
      cea6e702 (origin/feature/locked-sd-check) Check if the SD card is writable before starting the install (!1772)
    x 1fffe83d Add "crossdirect": faster cross compiling (!1758)
    ✔ 7f9bfee7 Add "pmbootstrap build --no-depends" (!1769)
    ✔ f23afed2 Cosmetic: remove confusing init_buildenv comments (!1769)
    ✔ a7985399 (tag: 1.5.1) Prepare 1.5.1 release

    P.S. yeah, verified, 1fffe83d breaks build.

    By Alexey Min on 2019-04-04T12:21:09

    Edited by Administrator
  • Administrator added 2 commits · Imported

    added 2 commits

    • 39971739 - 1 commit from branch postmarketOS:master
    • c994486a - hybris/*: enable building for armv7

    Compare with previous version

    By Alexey Min on 2019-04-04T20:23:18

  • Author Owner

    Is this fail a manifestation of https://gitlab.com/postmarketOS/pmbootstrap/issues/1715 ?

    By Alexey Min on 2019-04-04T20:54:02

  • Author Owner

    Thank you very much for the MR @minlexx, and thanks a lot for figuring out that the crossdirect stuff broke it. It is still very new, and needs more fixing - but when that is through, cross compiling will be much faster than before. Sorry for the inconvenience.

    I can take a look at this in detail tomorrow.

    By Oliver Smith on 2019-04-04T21:37:25

  • Administrator added 2 commits · Imported

    added 2 commits

    • 8a22cce6 - 1 commit from branch postmarketOS:master
    • 1b6ba4a0 - hybris/*: enable building for armv7

    Compare with previous version

    By Alexey Min on 2019-04-05T09:48:43

  • Administrator
  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Oliver Smith on 2019-04-05T22:28:36

  • Administrator resolved all discussions · Imported

    resolved all discussions

    By Oliver Smith on 2019-04-05T22:28:41

  • Author Owner

    Let's ship this. Thanks again @minlexx!

    By Oliver Smith on 2019-04-05T22:29:34

  • Administrator added 2 commits · Imported

    added 2 commits

    Compare with previous version

    By Oliver Smith on 2019-04-05T22:30:17

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2019-04-05T22:30:28

  • Administrator enabled an automatic merge when the pipeline for fb784b62 succeeds · Imported

    enabled an automatic merge when the pipeline for fb784b62 succeeds

    By Oliver Smith on 2019-04-05T22:30:30

  • Administrator merged · Imported

    merged

    By Oliver Smith on 2019-04-05T22:31:33

  • Administrator mentioned in issue #228 (closed) · Imported

    mentioned in issue #228 (closed)

    By Oliver Smith on 2019-04-05T22:34:28

  • Author Owner

    FYI: You can disable the crossdirect feature with pmbootstrap --no-crossdirect build ... in pmbootstrap master. I'll investigate the error that happened with building libhybris with crossdirect in #228 (closed).

    By Oliver Smith on 2019-04-05T22:35:39

  • Administrator mentioned in commit fb784b62 · Imported

    mentioned in commit fb784b62

    By Alexey Min on 2019-04-11T08:57:44

  • Please register or sign in to reply
    Loading