Skip to content
Snippets Groups Projects

firmware/firmware-aosp-broadcom-wlan: add armv7 arch

Merged Imported Administrator requested to merge broadcom_armv7 into master

Adds armv7 support for firmware-aosp-broadcom-wlan.

I tested this on htc-ace and was able to connect and use wi-fi.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator mentioned in merge request !304 (merged) · Imported

    mentioned in merge request !304 (merged)

    By Martin Piatka on 2019-04-06T19:24:49

  • Author Owner

    Should it be noarch at all? Does it contain architecture-dependent binaries?

    By Alexey Min on 2019-04-06T21:00:17

  • Author Owner

    I think it only contains firmware binary *.bin files. I don't know how it precisely works, but I think those are loaded into the wlan module which then executes them, so it probably is architecture independent.

    However, I've checked some of the other firmware packages and they too seem to have some architecture set, despite containing only what looks like architecture independent files.

    By Martin Piatka on 2019-04-06T21:12:25

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Oliver Smith on 2019-04-07T14:01:11

  • Author Owner

    We could make all firmware packages "noarch" packages. But most of them are not really needed for all arches, especially the device-specific firmware packages. So having them only built for the arches where we need them seems to be a good idea because then the overall amount of packages that need to be built (across all arches) is lower.

    Thanks for the patch @mpiatka, change looks good!

    By Oliver Smith on 2019-04-07T14:04:54

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2019-04-07T14:04:57

  • Administrator merged · Imported

    merged

    By Oliver Smith on 2019-04-07T14:05:01

  • Administrator mentioned in commit 7e742e2c · Imported

    mentioned in commit 7e742e2c

    By Bart Ribbers on 2019-05-06T13:59:55

Please register or sign in to reply
Loading