Skip to content
Snippets Groups Projects

mkinitfs: Introduce deviceinfo_append_dtb variable

Merged Imported Administrator requested to merge mkinitfs_dtb into master

We don't need to append the dtb to the kernel image in all cases, with e.g. the u-boot bootloader we can load the dtb seperately from the kernel image. Introduce a new variable deviceinfo_append_dtb, if set to "true", append the dtb, otherwise just copy the dtb file to the boot partition.

Fixes #260 (closed)

The WIP items are:

  • Some devices need the _mainline variable for the deviceinfo_dtb and deviceinfo_append_dtb variable now, as it's a hard fail now if the dtb file doesn't actually exist instead of just a warning.
  • Change should be tested on the two Pine devices (should work fine though)
  • The new variable has to be documented somewhere
  • Maybe change the naming of the mkinitfs function as it now does something a bit different
  • bump all the pkgrels
Edited by Administrator

Merge request reports

Checking pipeline status.

Merged by AdministratorAdministrator 5 years ago (Jun 2, 2019 1:27am UTC)

Loading

Pipeline #193259 passed

Pipeline passed for 693079ab on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Luca Weiss on 2019-05-27T17:21:38

  • Administrator changed the description · Imported

    changed the description

    By Luca Weiss on 2019-05-27T17:43:49

  • Administrator added 9 commits · Imported

    added 9 commits

    Compare with previous version

    By Luca Weiss on 2019-05-30T09:17:17

  • Administrator assigned to @z3ntu · Imported

    assigned to @z3ntu

    By Luca Weiss on 2019-05-30T09:18:13

  • Administrator marked the checklist item bump all the pkgrels as completed · Imported

    marked the checklist item bump all the pkgrels as completed

    By Luca Weiss on 2019-05-30T10:13:04

  • Administrator marked the checklist item Change should be tested on the two Pine devices (should work fine though) as completed · Imported

    marked the checklist item Change should be tested on the two Pine devices (should work fine though) as completed

    By Luca Weiss on 2019-05-30T10:13:08

  • Administrator added 1 commit · Imported

    added 1 commit

    • 8724eee7 - mkinitfs: Introduce deviceinfo_append_dtb variable

    Compare with previous version

    By Luca Weiss on 2019-05-30T10:47:50

  • Administrator marked the checklist item Some devices need the _mainline variable for the deviceinfo_dtb and deviceinfo_append_dtb variable now, as it's a hard fail now if the dtb file doesn't actually exist instead of just a warning. as completed · Imported

    marked the checklist item Some devices need the _mainline variable for the deviceinfo_dtb and deviceinfo_append_dtb variable now, as it's a hard fail now if the dtb file doesn't actually exist instead of just a warning. as completed

    By Luca Weiss on 2019-05-30T10:48:32

  • Author Owner

    This should be review-able now as my major todos are done!

    By Luca Weiss on 2019-05-30T10:49:27

  • Author Owner

    Looks good to me! Let's rename the function, document the option in the wiki, and ship it!

    https://wiki.postmarketos.org/wiki/Deviceinfo

    By Oliver Smith on 2019-05-30T23:00:28

  • Administrator
  • Administrator marked the checklist item Maybe change the naming of the mkinitfs function as it now does something a bit different as completed · Imported

    marked the checklist item Maybe change the naming of the mkinitfs function as it now does something a bit different as completed

    By Luca Weiss on 2019-05-31T09:21:53

  • Administrator added 15 commits · Imported

    added 15 commits

    Compare with previous version

    By Luca Weiss on 2019-05-31T09:22:00

  • Administrator marked the checklist item The new variable has to be documented somewhere as completed · Imported

    marked the checklist item The new variable has to be documented somewhere as completed

    By Luca Weiss on 2019-05-31T09:32:43

  • Administrator unmarked as a Work In Progress · Imported

    unmarked as a Work In Progress

    By Luca Weiss on 2019-05-31T09:32:52

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading