Skip to content
Snippets Groups Projects

Draft: lenovo-phab: new device

Closed Imported Draft: lenovo-phab: new device
lenovo-phab into master
5 unresolved threads
Closed Imported Administrator requested to merge lenovo-phab into master
5 unresolved threads

Merge request reports

Closed by AdministratorAdministrator 1 year ago (Jul 17, 2023 8:04pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator approved this merge request · Imported

    approved this merge request

    By Newbyte on 2023-02-16T10:34:40

  • Administrator added category::device device-category::testing type::feature labels · Imported

    added category::device device-category::testing type::feature labels

  • Administrator resolved all threads · Imported

    resolved all threads

    By Oleksandr Knyshuk on 2023-02-16T10:53:10

  • Administrator added 1 commit · Imported

    added 1 commit

    • 002c540f - lenovo-phab: decrease device package pkgver as suggested

    Compare with previous version

    By Oleksandr Knyshuk on 2023-02-16T10:53:12

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Oleksandr Knyshuk on 2023-02-16T11:08:32

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Oleksandr Knyshuk on 2023-02-16T11:27:29

  • Administrator resolved all threads · Imported

    resolved all threads

    By Newbyte on 2023-02-16T11:27:46

  • Administrator changed title from lenovo-phab: add device to lenovo-phab: new device · Imported

    changed title from lenovo-phab: add device to lenovo-phab: new device

    By Oleksandr Knyshuk on 2023-02-16T11:27:46

  • Administrator requested review from @Minecrell · Imported

    requested review from @Minecrell

    By Minecrell on 2023-02-16T14:35:17

  • Administrator
    Administrator @root started a thread on an old version of the diff
    • device/testing/device-lenovo-phab/APKBUILD 0 → 100644
    13
    14 subpackages="$pkgname-nonfree-firmware:nonfree_firmware"
    15
    16 build() {
    17 devicepkg_build $startdir $pkgname
    18 }
    19
    20 package() {
    21 devicepkg_package $startdir $pkgname
    22 }
    23
    24 nonfree_firmware() {
    25 pkgdesc="GPU/WiFi/BT/Modem/Video firmware"
    26 depends="firmware-qcom-adreno-a300 msm-firmware-loader
    27 firmware-qcom-msm8916-wcnss firmware-lenovo-phab-wcnss-nv
    28 firmware-qcom-msm8916-venus"
  • Administrator
    Administrator @root started a thread on the diff
    • device/testing/device-lenovo-phab/deviceinfo 0 → 100644
    8 deviceinfo_year="2016"
    9 deviceinfo_dtb="qcom/msm8916-lenovo-phab"
    10 deviceinfo_append_dtb="true"
    11 deviceinfo_arch="aarch64"
    12
    13 # Device related
    14 deviceinfo_chassis="handset"
    15 deviceinfo_keyboard="false"
    16 deviceinfo_external_storage="true"
    17 deviceinfo_screen_width="720"
    18 deviceinfo_screen_height="1280"
    19 deviceinfo_getty="ttyMSM0;115200"
    20 deviceinfo_gpu_accelerated="true"
    21
    22 # MSM DRM cannot take over the framebuffer from the bootloader at the moment
    23 deviceinfo_no_framebuffer="true"
    • Administrator
      Administrator @root · Imported
      Author Owner

      Please add the panel module to deviceinfo_modules_initfs instead, then the splash screen will work and you can remove this.

      By Minecrell on 2023-02-16T14:37:46

    • Please register or sign in to reply
    • Administrator
      Administrator @root · Imported
      Author Owner

      This needs to wait until we have support for this device in linux-postmarketos-qcom-msm8916 (just making this comment to make sure it's not already merged before).

      By Minecrell on 2023-02-16T14:38:52

  • Administrator added 1 commit · Imported

    added 1 commit

    • f759c57d - lenovo-phab: decrease tabulation in APKBUILD

    Compare with previous version

    By Oleksandr Knyshuk on 2023-02-16T14:58:49

  • Administrator marked this merge request as draft · Imported

    marked this merge request as draft

    By clayton craft on 2023-02-23T05:56:54

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Oleksandr Knyshuk on 2023-02-23T11:07:45

  • Administrator
    Administrator @root started a thread on the diff
    • device/testing/device-lenovo-phab/deviceinfo 0 → 100644
    12
    13 # Device related
    14 deviceinfo_chassis="handset"
    15 deviceinfo_keyboard="false"
    16 deviceinfo_external_storage="true"
    17 deviceinfo_screen_width="720"
    18 deviceinfo_screen_height="1280"
    19 deviceinfo_getty="ttyMSM0;115200"
    20 deviceinfo_gpu_accelerated="true"
    21
    22 # MSM DRM cannot take over the framebuffer from the bootloader at the moment
    23 deviceinfo_no_framebuffer="true"
    24
    25 # Bootloader related
    26 deviceinfo_flash_method="fastboot"
    27 deviceinfo_kernel_cmdline="earlycon console=tty0 ignore_loglevel debug"
    • Administrator
      Administrator @root · Imported
      Author Owner
      Suggested change
      27 deviceinfo_kernel_cmdline="earlycon console=tty0 ignore_loglevel debug"
      27 deviceinfo_kernel_cmdline="earlycon console=ttyMSM0,115200 PMOS_NO_OUTPUT_REDIRECT"

      console=ttyMSM0,115200 for releases.

      By Raymond Hackley on 2023-02-25T15:21:28

    • Please register or sign in to reply
  • Administrator
    Administrator @root started a thread on the diff
    • device/testing/firmware-lenovo-phab/APKBUILD 0 → 100644
    1 pkgname=firmware-lenovo-phab
    2 pkgver=2
  • Administrator added status::mr-stale label · Imported

    added status::mr-stale label

  • Administrator
    Administrator @root · Imported
    Author Owner

    Sorry to bother you @seqfault,

    but we've detected that this merge request hasn't seen any recent activity. If you need help or want to discuss your approach with developers you can ping @postmarketOS. You can also ask on matrix in #devel:postmarketos.org or #postmarketos-devel on OFTC. If no further activity occurs in this MR, postmarketOS developers may close it in the future.

    Thanks for your contribution.

    By * postmarketOS Bot on 2023-03-27T16:00:02

  • Administrator
    Administrator @root · Imported
    Author Owner

    Closing since there haven't been any updates in several months. Please re-open if you'd like to continue working on this.

    By clayton craft on 2023-07-17T20:04:19

  • Administrator closed · Imported

    closed

    • Please register or sign in to reply