Skip to content
Snippets Groups Projects

main/devicepkg-dev: add kernel scripts and config fragments

Merged Imported Administrator requested to merge kconfig into kconfig-fragments

It simplifies kernel packaging and reduces some steps in the maintaining process. Kernel fork owners don't have to maintain kernel config in pmaports anymore as long as they have a defconfig in the fork

Using linux-postmarketos-grate as a test subject

Important note

This MR is to a kconfig-fragments and not to master, @craftyguy thinks this can be merged with just 1 approval instead of the usual 2. The 1 approval should probably come from either @jenneron or @craftyguy, ask us if you have questions.

Edited by Administrator

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator added 2 commits · Imported

    added 2 commits

    • bbbd6244 - main/devicepkg-dev: add kernel scripts and config fragments
    • ea40e8c0 - linux-postmarketos-grate: use devicepkg-dev

    Compare with previous version

    By jenneron on 2023-12-24T10:42:26

  • Administrator added 2 commits · Imported

    added 2 commits

    • 7a032749 - main/devicepkg-dev: add kernel scripts and config fragments
    • 3024f3b0 - linux-postmarketos-grate: use devicepkg-dev

    Compare with previous version

    By jenneron on 2023-12-24T11:09:02

  • Administrator resolved all threads · Imported

    resolved all threads

    By jenneron on 2023-12-24T11:09:08

  • Administrator added 2 commits · Imported

    added 2 commits

    • 892718a1 - main/devicepkg-dev: add kernel scripts and config fragments
    • cae6dac5 - linux-postmarketos-grate: use devicepkg-dev

    Compare with previous version

    By jenneron on 2023-12-24T11:17:06

  • Author Owner

    some TODOs:

    • add verify function to prepare
    • add versioned configs
    • use it in other kernels

    not necessary for this MR, can be done in follow-ups

    By jenneron on 2023-12-24T18:13:54

  • Administrator added 1 commit · Imported

    added 1 commit

    • 2f532673 - linux-postmarketos-grate: use devicepkg-dev

    Compare with previous version

    By jenneron on 2023-12-25T08:08:12

    • Author Owner
      Resolved by Administrator

      The idea of doing config fragments has been discussed a lot in the past and we could never come up with a good way to do it, although perfect may be the enemy of good in this case.

      The biggest issue is that handling multiple kernel versions is hard, CONFIG options aren't stable and have been arbitrarily added/removed/modified. Limiting them to only maintained/mainline devices simplifies this but also limits the utility of having fragments in the first place - what do they solve that pmbootstrap kconfig check doesn't?

      The other big issue is that it means a kernel that might be working fine breaks due to a change in the config fragments, this could be pretty infuriating to track down.

      Overall I'd say I'm not against this approach - if it helps with your workflow and doesn't impede others then I certainly wouldn't NAK it - but I don't think I'd use it for the SDM845 kernel.

      By Caleb Connolly on 2024-01-01T23:45:51

      Edited by Ghost User
  • Administrator
  • Administrator
  • Administrator
  • Administrator added 2 commits · Imported

    added 2 commits

    • 6add86b4 - main/devicepkg-dev: add kernel scripts and config fragments
    • 4d74821a - linux-postmarketos-grate: use devicepkg-dev

    Compare with previous version

    By jenneron on 2023-12-26T18:59:18

  • Administrator changed the description · Imported

    changed the description

    By jenneron on 2023-12-26T19:00:09

  • Administrator added 2 commits · Imported

    added 2 commits

    • 7ef706cf - main/devicepkg-dev: add kernel scripts and config fragments
    • 7963b193 - linux-postmarketos-grate: use devicepkg-dev

    Compare with previous version

    By jenneron on 2023-12-28T19:47:01

  • Administrator mentioned in epic &2 · Imported

    mentioned in epic &2

    By clayton craft on 2023-12-29T20:20:15

  • Administrator mentioned in issue #2492 · Imported

    mentioned in issue #2492

    By jenneron on 2023-12-30T10:45:32

  • Administrator mentioned in issue pmbootstrap#2286 · Imported

    mentioned in issue pmbootstrap#2286

    By jenneron on 2023-12-30T10:51:15

  • Administrator mentioned in issue pmbootstrap#2285 (closed) · Imported

    mentioned in issue pmbootstrap#2285 (closed)

    By jenneron on 2023-12-30T10:51:34

  • Administrator mentioned in issue #2490 (closed) · Imported

    mentioned in issue #2490 (closed)

    By jenneron on 2023-12-30T10:54:58

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading