unity8/mir: bump pkgrel after soname bump

This is why the upstream compat test case is currently failing in master.

Increase 'mir' pkgrel (1 -> 2), missing depend(s): so:libprotobuf-lite.so.17

added 1 deleted label

It is failing to build now :

[ 20%] Building CXX object src/server/scene/CMakeFiles/mirscene.dir/broadcasting_session_event_sink.cpp.o
In file included from /home/pmos/build/src/mir-1.1.2/src/server/frontend/session_mediator.cpp:19:
In file included from /home/pmos/build/src/mir-1.1.2/src/server/frontend/session_mediator.h:22:
In file included from /home/pmos/build/src/mir-1.1.2/src/server/frontend/display_server.h:22:
/home/pmos/build/src/mir-1.1.2/src/include/common/mir/protobuf/display_server.h:37:27: error: no type named 'Closure' in namespace 'google::protobuf'
        google::protobuf::Closure* done) = 0;
        ~~~~~~~~~~~~~~~~~~^
/home/pmos/build/src/mir-1.1.2/src/include/common/mir/protobuf/display_server.h:41:27: error: no type named 'Closure' in namespace 'google::protobuf'
        google::protobuf::Closure* done) = 0;
        ~~~~~~~~~~~~~~~~~~^
...

I'm on it.

---

• updating to 1.3.0 (latest) is not trivial, because it needs at least one new dependency: "wlcs" - and it does not seem to be packaged in Alpine already
  • (download URL would need to be changed since the .tar.xz archives are missing)
• looking at the source, updating to latest would not fix the build issue anyway: the files in question have seen the last change two years ago.
• that means, patching the source is the remaining option.
• protobuf was updated from 3.6.1 to 3.8.0 in alpine

By Oliver Smith on 2019-07-05T20:37:39

I noticed recently that a couple of new mir versions were released so they probably fix compatibility with the new protobuf version

By Luca Weiss on 2019-07-05T20:20:11

Unfortunately they don't, see the edits above^^

By Oliver Smith on 2019-07-05T20:25:19

Saw it after writing the message (edits don't show up in the email inbox^^ and because gitlab loves to log me out on my phone I'm always answering via email from when I'm on my phone)

By Luca Weiss on 2019-07-05T20:27:46

Yeah, I did the edit on purpose, so I don't generate e-mails with small research updates. But if you follow along, I can also make full comments here.

I'm trying to patch it myself now, can reproduce it with pmbootstrap build --src so far.

By Oliver Smith on 2019-07-05T20:30:53

On second thought, that would lead to way too many mails, so I'll just edit that upper post again.

By Oliver Smith on 2019-07-05T20:37:02

After spending two and a half hours on this and almost puking when seeing the protobuf git log, I don't see how I can fix this or create a workaround in reasonable time.

I have reported the build failure with 3.8.0 upstream: https://github.com/MirServer/mir/issues/913

Unfortunately we'll need to remove mir from pmaports.git and all dependencies, until this is resolved.

By Oliver Smith on 2019-07-05T21:43:51

closed

By Oliver Smith on 2019-07-05T21:43:52

Actually I'm past that specific error now, see the bug report. Compilation is stuck at 33% now, with another error. I'll try some more to get it building again.

By Oliver Smith on 2019-07-05T22:17:30

reopened

By Oliver Smith on 2019-07-06T00:56:54

added 1 commit

• 256b8c18 - unity8/mir: rebuild against protobuf 3.8.0

Compare with previous version

By Oliver Smith on 2019-07-06T00:58:01

added 1 commit

• 3bb55046 - unity8/mir: rebuild against protobuf 3.8.0 (!481 (merged))

Compare with previous version

By Oliver Smith on 2019-07-06T01:19:07

mentioned in commit 3bb55046

By Oliver Smith on 2019-07-06T01:19:08

enabled an automatic merge when the pipeline for 3bb55046 succeeds

By Oliver Smith on 2019-07-06T01:19:31

Yay, finally the build works again!

Maybe the second patch I've added will even fix the build for arm? This could be looked into if somebody is interested. It would also be nice to update mir to the latest version.

By Oliver Smith on 2019-07-06T01:21:39

merged

By Oliver Smith on 2019-07-06T01:22:17

It looks like you spent a bunch of time on this. Congrats for fixing the issue ^^ ;)

By Luca Weiss on 2019-07-06T07:21:27