Skip to content
Snippets Groups Projects

Add new device: lg-w5 (LG L70)

Merged Imported Administrator requested to merge lg-w5 into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Paakke on 2018-09-08T15:00:42

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Paakke on 2018-09-08T15:06:02

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Paakke on 2018-09-08T15:46:14

  • Author Owner

    Thanks for the MR! Could you rebase your branch on the latest master? There is a fix in there for the current musl compilation failure which is breaking the CI.

    By Bart Ribbers on 2018-09-08T21:12:01

  • Administrator added 2 commits · Imported

    added 2 commits

    • ba0ba4e8 - 1 commit from branch postmarketOS:master
    • e0aefbed - Add new device: lg-w5 (LG L70)

    Compare with previous version

    By Paakke on 2018-09-09T17:46:52

  • Author Owner

    Awesome, tests went through successfully now. Is the device wiki page accurate? It seems only usb networking works? Flashing not working would mean you probably live boot it using a sdcard, could you add that to the installation instructions like the device page template requests?

    By Bart Ribbers on 2018-09-09T22:11:55

  • Author Owner

    OK, done. https://wiki.postmarketos.org/wiki/LG_L70_(lg-w5)

    By Paakke on 2018-09-11T14:21:54

  • Author Owner

    Seems good now. For the next time, please change the status fields in the info box of the wiki page to the actual status: empty if not working or not tested, P if partially working, Y if working.

    Right now you have the following:

    [[Category:Devices]]
    {{Infobox device
    | manufacturer = LG
    | name =  LG L70
    | codename = lg-w5
    | releaseyear = 2014
    | originalsoftware = Android 4.4.2 (KitKat)
    | chipset = Qualcomm MSM8210 Snapdragon 200
    | cpu = Dual-core 1.2 GHz Cortex-A7
    | gpu = Adreno 302
    | storage = 4 GB
    | display = 480 x 800 IPS LCD
    | memory = 1 GB
    | architecture = CHANGE_ME
    | status_usbnet = Y
    | status_flashing = CHANGE_ME
    | status_touch = CHANGE_ME
    | status_screen = N
    | status_wifi = CHANGE_ME
    | status_xwayland = CHANGE_ME
    | status_fde = CHANGE_ME
    | status_mainline = CHANGE_ME
    | status_battery = CHANGE_ME
    | status_3d = CHANGE_ME
    | status_accel = CHANGE_ME
    | status_audio = CHANGE_ME
    | status_bluetooth = CHANGE_ME
    | status_camera = CHANGE_ME
    | status_gps = CHANGE_ME
    | status_mobiledata = CHANGE_ME
    | status_sms = CHANGE_ME
    | status_calls = CHANGE_ME
    | booting = Y
    }}

    I've removed all "CHANGE_ME"'s myself for now.

    By Bart Ribbers on 2018-09-11T22:21:50

  • Administrator added category::device label · Imported

    added category::device label

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2018-09-13T06:13:26

  • Administrator added 2 commits · Imported

    added 2 commits

    • 99a676dc - 1 commit from branch postmarketOS:master
    • ea51a511 - Add new device: lg-w5 (LG L70)

    Compare with previous version

    By Oliver Smith on 2018-09-13T06:13:35

  • Author Owner

    Code looks good.

    And I can see that it's a bit intimidating to see such a big list of CHANGEMEs in the wiki page. When a port has just started, most of the status columns are empty anyway, so I've put blanks there. I've also updated the template to provide a bit more hand holding, so it's easier to see what's going in the columns.

    Thanks @PureTryOut for fixing up the wiki page! Thank you for the device port @Paakke!

    By Oliver Smith on 2018-09-13T06:55:50

  • Administrator merged · Imported

    merged

    By Oliver Smith on 2018-09-13T06:56:23

Please register or sign in to reply
Loading