main/postmarketos-update-kernel: deal with dtb on older devices boot-deploy#26

Fixes the script which in absence of vmlinuz-dtb since boot-deploy!50 (merged) made the device unusable.

Tested on samsung-i9100.

By MC Dev on 2024-04-12T21:39:16

added 1 commit

• 345fd67f - main/postmarketos-update-kernel: deal with dtb on older devices #26 (closed)

Compare with previous version

By MC Dev on 2024-04-12T21:42:44

added 1 commit

• c44cd89f - main/postmarketos-update-kernel: deal with dtb on older devices boot-deploy#26 (closed)

Compare with previous version

By MC Dev on 2024-04-12T21:45:04

changed title from main/postmarketos-update-kernel: deal with dtb on older devices #26 (closed) to main/postmarketos-update-kernel: deal with dtb on older devices boot-deploy#26 (closed)

By MC Dev on 2024-04-12T21:45:34

changed the description

By MC Dev on 2024-04-12T21:46:01

changed the description

By MC Dev on 2024-04-12T21:46:29

added 1 commit

• 7515318a - main/postmarketos-update-kernel: deal with dtb on older devices boot-deploy#26 (closed)

Compare with previous version

By MC Dev on 2024-04-12T21:50:57

added 1 commit

• 2fb1cce9 - main/postmarketos-update-kernel: deal with dtb on older devices boot-deploy#26 (closed)

Compare with previous version

By MC Dev on 2024-04-12T21:52:14

approved this merge request

By Caleb Connolly on 2024-04-12T22:00:43

added 3 commits

• 2fb1cce9...583ab0a2 - 2 commits from branch postmarketOS:master
• 8e507193 - main/postmarketos-update-kernel: deal with dtb on older devices boot-deploy#26 (closed)

Compare with previous version

By MC Dev on 2024-04-13T07:11:37

added 1 commit

• 0dd210f3 - main/postmarketos-update-kernel: deal with dtb on older devices boot-deploy#26 (closed)

Compare with previous version

By MC Dev on 2024-04-13T07:24:11

added 1 commit

• 95d33d4c - main/postmarketos-update-kernel: deal with dtb on older devices boot-deploy#26 (closed)

Compare with previous version

By MC Dev on 2024-04-13T07:25:17

Changes look good, should fix kernel upgrades for i9100, thanks! Fresh installs with heimdall will still fail though (for that we don't run pmos-update-kernel)

Not sure why CI fails, seem to be unrelated error(?)

By Henrik Grimler on 2024-04-13T16:26:20

Not sure why CI fails, seem to be unrelated error(?)

It's probably related to the Python 3.12 upgrade in Alpine.

By Newbyte on 2024-04-13T16:26:20

First submission did not fail, likely so. What to do about it?

By MC Dev on 2024-04-13T16:26:20

What to do about it?

It needs to be figured out separately. You don't need to worry about it.

By Newbyte on 2024-04-14T17:04:20

I am currently working on removing this script altogether in https://gitlab.com/postmarketOS/boot-deploy/-/merge_requests/55. Do you think you could make this MR to boot-deploy instead once that's done? Thanks for working on this though!

By Newbyte on 2024-04-13T10:05:11

I'd like boot-deploy to be fixed too, as @grimler said, this MR only fixes kernel update after apk upgrade on the device.

By MC Dev on 2024-04-13T16:27:57

What I'm trying to say is that postmarketos-update-kernel is going away entirely soon and the code will be merged into boot-deploy, so it would be better to just fix boot-deploy as it will handle this business too (soon).

By Newbyte on 2024-04-13T16:59:08

Is boot-deploy used as well when doing apk upgrade on devices? If not the script could still be relevant. Anyhow, are you referring to having a similar change around https://gitlab.com/postmarketOS/boot-deploy/-/merge_requests/55/diffs#3426430484da3a896afc2dec20fac3ba2a0c189d_775_838 ?

By MC Dev on 2024-04-13T20:52:53

Is boot-deploy used as well when doing apk upgrade on devices?

Yes. boot-deploy is what calls this script.

Anyhow, are you referring to having a similar change around boot-deploy!55 (merged)?

That MR essentially imports this script into boot-deploy, and once that's done the copy in pmaports will go away.

By Newbyte on 2024-04-13T20:54:17

Would you suggest applying similar changes in boot-deploy!55 (merged) or after it is merged?

By MC Dev on 2024-04-14T17:05:36

Would you suggest applying similar changes in boot-deploy!55 (merged) (merged) or after it is merged?

Yes, I suggest sending an MR that fixes this in boot-deploy now that my MR integrating this script in there has been merged. Sorry about the bad timing with this.

By Newbyte on 2024-04-18T13:17:10

Closing in favor of !5044 (merged) and !5045 (merged)

By Pablo Correa Gomez on 2024-04-18T13:16:05

Those doesn't resolve what this MR aimed to do, but this MR is not the right approach regardless given that it only works on subsequent boots and not the initial one.

By Newbyte on 2024-04-18T13:16:15

closed