Skip to content
Snippets Groups Projects

temp/xkeyboard-config: Fork from alpine to add N900 extended layout

Merged Imported Administrator requested to merge feature/n900-extended-layout into master
All threads resolved!

This fork is to apply the extended N900 layout using the patches from https://github.com/archlinuxarm-n900/xkeyboard-config-n900-git

TODO:

  • test on N900

Closes #87 (closed)

Edited by Administrator

Merge request reports

Checking pipeline status.

Approval is optional

Merged by AdministratorAdministrator 5 years ago (Jul 25, 2019 7:05pm UTC)

Merge details

Pipeline #195394 passed

Pipeline passed for ceb3c2a2 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Owner

    So the only interesting file generated by this aport is the rx-51 file, which is now using the advanced layout: https://pkgs.alpinelinux.org/contents?file=rx-51&path=&name=xkeyboard-config&branch=edge&repo=main&arch=armv7

    How about we change the build() function to install just that one file to /usr/share/X11/xkb/symbols/nokia_vndr/rx-51-advanced or something like that? My hope is, that we then would not need to fork the package.

    By Oliver Smith on 2019-07-18T21:59:18

    • Author Owner
      Resolved by Administrator

      @ollieparanoid this was the solution discussed in #87 (closed), because creating a new layout also requires to add an entry to the evdev.xml rules file, which might be more complicated

      Ideally would be to upstream those patches to alpine or directly to xkeyboard-config, but don't know if they want this customized layout.

      By Daniele Debernardi on 2019-07-20T21:07:46

      Edited by Ghost User
  • Administrator added 1 commit · Imported

    added 1 commit

    • 5aafc12b - temp/xkeyboard-config: Fork from alpine to add N900 extended layout

    Compare with previous version

    By Daniele Debernardi on 2019-07-19T22:24:17

  • Author Owner

    @PureTryOut @ollieparanoid As suggested I've downloaded the patches and added directly to the folder (reverting the prepare function).

    In the meantime I also added another patch to extend the Swiss layout with the symbols like we have for the console, and most importantly fixed the arrow keys.

    Now it matches the keys described in the image

    PS: Not tested yet on the device, just used the backed up rx-51 file I had around to create the diff patch

    By Daniele Debernardi on 2019-07-19T22:32:25

  • Administrator added 11 commits · Imported

    added 11 commits

    Compare with previous version

    By Daniele Debernardi on 2019-07-19T23:14:04

  • Administrator resolved all threads · Imported

    resolved all threads

    By Oliver Smith on 2019-07-20T21:02:51

  • Author Owner

    Changes look good to me! Let's wait with merging until it is tested on the device, afterwards it is ready to go.

    By Oliver Smith on 2019-07-20T21:08:53

  • Administrator changed the description · Imported

    changed the description

    By Daniele Debernardi on 2019-07-21T17:09:14

  • Author Owner

    I'm currently testing both the layouts (us and ch) and I just found a missing useful key combination in the US layout, the page up/down.
    I'll add another patch to add it.

    By Daniele Debernardi on 2019-07-22T22:44:25

  • Author Owner

    Ok, I've tested it wrongly, the pageUp/pageDown keys are binded correctly by the patch [PATCH 03/10] RX-51: Symbols: Bind PgUp, PgDown, Home, End to third for the US layout.

    The problem with scrolling the log in the terminal is that by default is done with Shift+PageUp, unfortunately on the N900 the shift key is already pressed to perform the pageUp key itself.

    I tested with other programs and the keys are working correctly, so I think the MR is ready to be closed

    By Daniele Debernardi on 2019-07-23T21:59:14

  • Administrator marked the checklist item test on N900 as completed · Imported

    marked the checklist item test on N900 as completed

    By Daniele Debernardi on 2019-07-23T21:59:18

  • Administrator added 12 commits · Imported

    added 12 commits

    Compare with previous version

    By Oliver Smith on 2019-07-25T19:00:30

  • Administrator mentioned in commit ceb3c2a2 · Imported

    mentioned in commit ceb3c2a2

    By Daniele Debernardi on 2019-07-25T19:00:39

  • Administrator resolved all threads · Imported

    resolved all threads

    By Oliver Smith on 2019-07-25T19:00:57

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2019-07-25T19:01:24

  • Author Owner

    Awesome, thanks again @drebrez!

    By Oliver Smith on 2019-07-25T19:01:41

  • Administrator merged · Imported

    merged

    By Oliver Smith on 2019-07-25T19:05:36

  • Please register or sign in to reply
    Loading