Skip to content
Snippets Groups Projects

main/postmarketos-mkinitfs: set pmOS-specific firmware path

Merged Imported Administrator requested to merge firmware-path into master
All threads resolved!

Currently we rely on the fact, that the kernel asks user space to load the firmware for it, so we can use the /lib/firmware/postmarketos directory for firmware.

As the kernel has support for loading the firmware itself since v3.7, and the parameter for adding an additional path to the search paths was added with v3.10, we can use that to not rely on CONFIG_FW_LOADER_USER_HELPER being set.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Luca Weiss on 2019-07-21T10:51:37

  • Administrator mentioned in merge request pmbootstrap!1803 (closed) · Imported

    mentioned in merge request pmbootstrap!1803 (closed)

    By Luca Weiss on 2019-07-21T11:36:51

    • Author Owner
      Resolved by Administrator

      I wasn't aware of /lib/firmware/postmarketos for some reason, but I use firmware_class.path=/lib/firmware/<device> to have a device-specific firmware directory. This change would always replace my kernel parameter :)

      What is the purpose of /lib/firmware/postmarketos? If it exists to avoid conflicting files with Alpine's linux-firmware packages, then having something like /lib/firmware/<device> would be preferable in my opinion to also avoid conflicts between device-specific firmware packages.

      It looks like only one additional firmware directory can be set with this parameter, so maybe we could have a deviceinfo variable to change it?

      By lambdadroid on 2019-07-22T07:35:04

    • Author Owner
      Resolved by Administrator

      @lambdadroid Yes, /lib/firmware/postmarketos gets used for non-linux-firmware firmware that is very likely device-specific.

      I don't think it's worth changing a bunch of firmware apkbuilds to change that path - it works fine as it is. But you should be able to remove the firmware_class.path=/lib/firmware/postmarketos parameter on samsung-gts210ve* once this is merged.

      By Luca Weiss on 2019-07-22T16:05:01

      Edited by Ghost User
  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Luca Weiss on 2019-07-22T15:59:55

  • Administrator mentioned in commit 7699f8d5 · Imported

    mentioned in commit 7699f8d5

    By Luca Weiss on 2019-07-25T18:30:36

  • Administrator added 10 commits · Imported

    added 10 commits

    Compare with previous version

    By Oliver Smith on 2019-07-25T18:30:37

  • Administrator resolved all threads · Imported

    resolved all threads

    By Oliver Smith on 2019-07-25T18:32:04

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2019-07-25T18:32:16

  • Author Owner

    LGTM. Thanks @z3ntu!

    By Oliver Smith on 2019-07-25T18:32:45

  • Administrator merged · Imported

    merged

    By Oliver Smith on 2019-07-25T18:48:58

  • Administrator mentioned in merge request !807 (merged) · Imported

    mentioned in merge request !807 (merged)

    By Minecrell on 2019-12-13T12:34:44

  • Please register or sign in to reply
    Loading