Skip to content
Snippets Groups Projects

Some fixes for plasma-mobile

Merged Imported Some fixes for plasma-mobile
bshah/update-phone-components into master
All threads resolved!
Merged Imported Administrator requested to merge bshah/update-phone-components into master
All threads resolved!
  • Update plasma-phone-components to latest version
  • Add kirigami-gallery as dep to postmarketos-ui-plasma-mobile
  • Add workaround for broken fonts on pine devices with lima.

Don't squash the branch please.

Merge request reports

Approved by
Administrator

Merged by AdministratorAdministrator 5 years ago (Jul 30, 2019 8:49pm UTC)

Merge details

  • Changes merged into master with eb154010.
  • Deleted the source branch.

Pipeline #195729 passed

Stage: first
Stage: second

Pipeline passed for eb154010 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
    Administrator @root · Imported
    Author Owner

    @PureTryOut review please. I know you don't like kirigami-gallery in UI package, but I disagree :stuck_out_tongue:

    @MartijnBraam this should fix fonts on pine* devices.

    By Bhushan Shah on 2019-07-30T06:48:52

  • Administrator
    Administrator @root · Imported
    Author Owner

    Yeah I dislike it, people can install it manually when they want too. At least add it postmarketos-ui-plasma-mobile-extra not the regular package, we try to keep that one as minimal as possible.

    By Bart Ribbers on 2019-07-30T12:59:03

  • Administrator
    Administrator @root · Imported
    Author Owner

    I think it makes sense to add to -extra since it's mostly development images now. for final images it makes less sense. but it's very very annoying when it's not available when something buggy happens and you have to reflash an image.

    By Martijn Braam on 2019-07-30T13:02:28

  • Administrator
  • Administrator
    Administrator @root · Imported
    Author Owner

    Thanks for the MR @bshah! :tada:

    Since we had quite some breakage with untested plasma mobile related MRs, it would be good to have a confirmation that this works on the pine tablet before merging. And also to see if the broken fonts are fixed :thumbsup:

    By Oliver Smith on 2019-07-30T18:06:19

  • Administrator
    Administrator @root · Imported
    Author Owner

    Broken fonts are fixed, yes. I've tested this in both pine devices.

    By Bhushan Shah on 2019-07-30T19:17:26

  • Administrator resolved all threads · Imported

    resolved all threads

    By Oliver Smith on 2019-07-30T20:41:52

  • Administrator added 6 commits · Imported

    added 6 commits

    Compare with previous version

    By Oliver Smith on 2019-07-30T20:44:46

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2019-07-30T20:45:47

  • Administrator enabled an automatic merge when the pipeline for eb154010 succeeds · Imported

    enabled an automatic merge when the pipeline for eb154010 succeeds

    By Oliver Smith on 2019-07-30T20:45:52

  • Administrator merged · Imported

    merged

    By Oliver Smith on 2019-07-30T20:49:37

  • Administrator mentioned in commit eb154010 · Imported

    mentioned in commit eb154010

    By Bhushan Shah on 2019-07-30T20:49:38

  • Administrator mentioned in commit c8c69dbc · Imported

    mentioned in commit c8c69dbc

    By Bhushan Shah on 2019-07-30T20:49:38

  • Administrator
    Administrator @root · Imported
    Author Owner

    Nitpick for next time: when upgrading a package, the commit message should say upgrade rather than update; Alpine standards.

    By Bart Ribbers on 2019-08-02T16:24:30

    • Please register or sign in to reply