Skip to content
Snippets Groups Projects

motorola-lux: new device

Merged Imported Administrator requested to merge device-motorola-lux into master
All threads resolved!

This is an initial device configuration for the motorola-lux (Moto X Play).

Working

  • USB networking
  • Display

Not working

  • Touchscreen

Everything else is untested

Edited by Administrator

Merge request reports

Merged by AdministratorAdministrator 5 years ago (Aug 23, 2019 11:13pm UTC)

Loading

Pipeline #196958 passed

Pipeline passed for 7bef09b4 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
  • Administrator
  • Administrator changed title from motorola-lux: Initial device integration to motorola-lux: new device · Imported

    changed title from motorola-lux: Initial device integration to motorola-lux: new device

    By Bart Ribbers on 2019-08-19T10:28:12

  • Administrator changed the description · Imported

    changed the description

    By Bart Ribbers on 2019-08-19T10:28:12

  • Administrator added 1 deleted label · Imported

    added 1 deleted label

  • Author Owner

    Awesome work, thanks for your contribution!

    Please squash your commits and reword it to be motorola-lux: new device (like I edited the title of this MR).

    By Bart Ribbers on 2019-08-19T10:29:48

  • Author Owner

    LGTM, but please squash the commits and resolve the requested changes

    By Danct12 on 2019-08-19T10:56:39

    Edited by Administrator
  • Author Owner

    Ok I will take a look at changing the architecture. The defconfig from LineageOS is for armhf so hopefully it won't cause too many problems using it on aarch64

    By Gavin Lilly on 2019-08-19T17:25:47

  • Author Owner

    I've had a few days to look at this and I'm not convinced that compiling on aarch64 is just as simple as changing from armhf to aarch64. The lineageos kernel sources only provide arm (i.e 32-bit) support for the motorola-lux.

    It may be possible to move some/all the Motorola specific code to arm64 but I don't think I have the knowledge to do so. Additionally I wonder if that effort would be better placed porting the Motorola code to the mainline kernel instead anyway.

    Perhaps the pragmatic way forward would be to integrate the device on armhf initially so it's at least in the device list?

    By Gavin Lilly on 2019-08-21T18:19:39

  • Author Owner

    It looks like the same would apply for motorola-[harpia, osprey, surnia] as they all use the same kernel sources and are based on Snapdragon 410. All are currently set to armhf in the pmaports device tree

    By Gavin Lilly on 2019-08-21T18:45:20

  • Administrator resolved all threads · Imported

    resolved all threads

    By Oliver Smith on 2019-08-23T23:07:20

  • Author Owner

    Thank you very much for the port @gavtherav, and also thanks for looking into whether changing the arch makes sense. I agree, if it is not a simple task, then let's keep the initial port at armhf and possibly change from there in a future commit (or as you pointed out, go straight to working on mainline).

    The patch looks good to me, let's ship it! :ship:

    By Oliver Smith on 2019-08-23T23:09:08

  • Administrator added 30 commits · Imported

    added 30 commits

    Compare with previous version

    By Oliver Smith on 2019-08-23T23:11:41

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2019-08-23T23:11:58

  • Administrator enabled an automatic merge when the pipeline for 7bef09b4 succeeds · Imported

    enabled an automatic merge when the pipeline for 7bef09b4 succeeds

    By Oliver Smith on 2019-08-23T23:11:59

  • Administrator merged · Imported

    merged

    By Oliver Smith on 2019-08-23T23:13:27

  • Administrator mentioned in commit 7bef09b4 · Imported

    mentioned in commit 7bef09b4

    By Daniele Debernardi on 2019-09-12T23:37:10

  • Please register or sign in to reply
    Loading