device-<qcom-msm8916>: revert to msdos partition table for now
pmbootstrap 3.0.0 uses GPT partition table by default, which breaks booting on all the devices using the lk2nd bootloader. The current version of lk2nd supports GPT only for the eMMC, while subpartitions and SD cards must be partitioned with MBR. GPT support was present in the legacy branch of lk2nd, but was dropped at some point because of poor code quality.
Fix the regression for now by reverting back to the old msdos (MBR) partition table. We can revert this again later when lk2nd restores support for GPT.
Generated with:
$ for d in $(grep -R linux-postmarketos-qcom-msm8916 | grep -Eo 'device-[^/]+' | sort -u); do \
echo -e '\n# lk2nd does not support GPT for subpartitions/SD cards yet\ndeviceinfo_partition_type="msdos"' \
>> device/*/$d/deviceinfo && pmbootstrap checksum $d && pmbootstrap pkgver_bump $d; done
Merge request reports
Activity
requested review from @TravMurav
changed milestone to %v24.12 Release
- Resolved by Clayton Craft
@craftyguy @caleb Do you have any ideas what's going on in the CI here?
[11:11:36] $ pmbootstrap /usr/local/bin/pmbootstrap --aports /builds/postmarketOS/pmaports --details-to-stdout init [11:11:36] Pmbootstrap v3.0.0 (Python 3.12.7 (main, Oct 7 2024, 11:30:19) [GCC 13.2.1 20240309]) [11:11:36] % /sbin/losetup --json [11:11:36] Location of the 'work' path. Multiple chroots (native, device arch, device rootfs) will be created in there. [11:11:36] Work path [/home/pmos/.local/var/pmbootstrap]: [11:11:36] Work path [/home/pmos/.local/var/pmbootstrap]: /home/pmos/.local/var/pmbootstrap [11:11:36] Save config: /home/pmos/.config/pmbootstrap_v3.cfg [11:11:36] % cd /builds/postmarketOS/pmaports; git remote -v [11:11:36] ERROR: pmaports: could not find remote name for any URL '['https://gitlab.postmarketos.org/postmarketOS/pmaports.git', 'git@gitlab.postmarketos.org:postmarketOS/pmaports.git']' in git repository: /builds/postmarketOS/pmaports [11:11:36] See also: <https://postmarketos.org/troubleshooting> [11:11:36] Traceback (most recent call last): File "/tmp/pmbootstrap/pmb/__init__.py", line 84, in main config_init.frontend(args) File "/tmp/pmbootstrap/pmb/config/init.py", line 733, in frontend channel = ask_for_channel(config) ^^^^^^^^^^^^^^^^^^^^^^^ File "/tmp/pmbootstrap/pmb/config/init.py", line 151, in ask_for_channel channels_cfg = pmb.helpers.git.parse_channels_cfg(pkgrepo_default_path()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/tmp/pmbootstrap/pmb/meta/__init__.py", line 42, in __call__ self.cache.cache[key] = self.func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/tmp/pmbootstrap/pmb/helpers/git.py", line 217, in parse_channels_cfg remote = get_upstream_remote(aports) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/tmp/pmbootstrap/pmb/helpers/git.py", line 130, in get_upstream_remote raise RuntimeError( RuntimeError: pmaports: could not find remote name for any URL '['https://gitlab.postmarketos.org/postmarketOS/pmaports.git', 'git@gitlab.postmarketos.org:postmarketOS/pmaports.git']' in git repository: /builds/postmarketOS/pmaports
Edited by Newbyte
- Resolved by Newbyte
I'm guessing we also need to backport this to v24.06?
added 1 commit
- 5752c31a - DO NOT MERGE ci: run arm 64-bit and 32-bit build test jobs on aarch64 runners
added 1 commit
- 6621dc07 - DO NOT MERGE ci: run arm 64-bit and 32-bit build test jobs on aarch64 runners
added 1 commit
- e22822f7 - device-<qcom-msm8916>: revert to msdos partition table for now (MR 5813)
added 8 commits
-
e22822f7...0924a7f2 - 7 commits from branch
postmarketOS:master
- 319396a6 - device-<qcom-msm8916>: revert to msdos partition table for now (MR 5813)
-
e22822f7...0924a7f2 - 7 commits from branch