Skip to content
Snippets Groups Projects

Draft: systemd/abuild: drop

Open Draft: systemd/abuild: drop
caleb/bootstrap-abuild into master
1 unresolved thread
Open Casey requested to merge caleb/bootstrap-abuild into master
1 unresolved thread

we have abuild in both the systemd and edge repos due to #3452

it seems like just adding an explicit bootstrap step is enough to get things going properly. That probably isn't even needed since it seems like the bootstrap failure we saw was specific to that scenario and probably wouldn't show up again. but better safe than sorry.

Fixes: #3452

Merge request reports

Merge request pipeline #213585 passed

Stage: lint
Stage: build

Merge request pipeline passed for 8c8947b0

Approval is optional
Merge blocked: 4 checks failed
Merge request must not be draft.
Unresolved discussions must be resolved.
Merge conflicts must be resolved.
Merge request must be rebased, because a fast-forward merge is not possible.

Merge details

  • The source branch is 608 commits behind the target branch.
  • 1 commit will be added to master.
  • Source branch will be deleted.

  • Closes issue #3452

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Casey requested review from @ollieparanoid

    requested review from @ollieparanoid

    • Oliver Smith
      Oliver Smith @ollieparanoid ·
      Maintainer

      Thanks for the patch! I don't think this fixes it for bpo unfortunately, from #3452:

      Without this change, BPO builds abuild, but then detects that this package does not belong in extra-repos/systemd and refuses to finish the bootstrap step. This is a safety mechanism, so we don't build unrelated packages in bootstrap by accident.

      So I'll need to fix this in bpo probably.

      Caleb wrote:

      it seems like just adding an explicit bootstrap step is enough to get things going properly. That probably isn't even needed since it seems like the bootstrap failure we saw was specific to that scenario and probably wouldn't show up again. but better safe than sorry.

      We'll see the same bootstrap errors when branching v25.06 and other future releases.

  • Oliver Smith marked this merge request as draft

    marked this merge request as draft

  • Clayton Craft mentioned in merge request !6065 (merged)

    mentioned in merge request !6065 (merged)

  • The Friendly Bot added status::mr-stale label

    added status::mr-stale label

  • The Friendly Bot
    The Friendly Bot @gitlab-bot ·
    Developer

    Sorry to bother you @caleb,

    but we've detected that this merge request hasn't seen any recent activity. If you need help, want to discuss your approach with developers, or you are all done and this is waiting for review, you can ping @postmarketOS. You can also ask on matrix in #devel:postmarketos.org or #postmarketos-devel on OFTC.

    Thanks for your contribution.

  • Pablo Correa Gomez
    Pablo Correa Gomez @pabloyoyoista ·
    Maintainer

    Can we close this now that we moved forward with the abuild patch?

  • Oliver Smith
    Oliver Smith @ollieparanoid ·
    Maintainer

    I plan to completely remove the bootstrap logic in favor of a simple systemd-stage0 package: #3604 (comment 474051) - as part of this, the extra-repos/systemd/abuild package can be dropped.

Please register or sign in to reply