Skip to content
Snippets Groups Projects

boot-deploy: create hooks dir

Open Rasmus Thomsen requested to merge Cogitri/pmaports:boot-deploy-hooks-dir into master
2 unresolved threads

It's a bit unintuitive having to go through boot-deploy's source to find out where to place hooks, so create the dir with a small README file

I have to admit it has been a minute since I've last touched an APKBUILD, so I hope I didn't mess this up too badly :D With boot-deploy's hooks I have been able to get secure boot going on generic-x86_64 :)

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline passed for 7fe19d03

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Packages you maintain have been changed: @craftyguy

    • @Cogitri

      I kinda prefer if this is documented also in the boot-deploy repo README.md (and maybe also install this README.md under /usr/share/docs in this pmaports package...), Mainly because it's not intuitive for me to look in dirs that almost never contain docs, like this one. Anyways, I appreciate you pointing this out, if you don't want to make the patch I described or disagree, let me know :)

      With boot-deploy's hooks I have been able to get secure boot going on generic-x86_64 :)

      Woooo! :grin:

    • I do agree with documenting it in boot-deploy's README.md - that certainly makes sense. Personally, I do feel like it's natural to have a documentation file in the /etc dir too - the kernel-hooks package does the exact same thing and actually is how I found out about the hooks, I probably wouldn't have looked into /usr/share/docs :D
      Would it be OK for you to mention it in boot-deploy's README and also add a smaller README focused on the hooks and install that to the hooks dir?

    • Adding to the README would make total sense. The rest is probably better discussed in an MR in that project :smile:

    • Nevermind, I failed to read boot-deploy!77...

    • Please register or sign in to reply
  • Newbyte
    Newbyte @Newbyte started a thread on a file
Please register or sign in to reply
Loading