linux-postmarketos-qcom-sdm845: update to 6.14-rc5 and add cameras for op6
Supersedes !6148 (closed).
Tested on:
-
Xiaomi Poco F1 (Tianma) -
Xiaomi Poco F1 (EBBG) -
Google Pixel 3
Requires Testing:
-
Oneplus 6 (especially the camera setup) - @caleb or anyone from the testing team
Optionally
-
Samsung S9 (picked up a lot commits recently, so it will be nice to have it tested - @dsankouski) -
Oneplus 6T -
Shiftmq6
Merge request reports
Activity
Packages you maintain have been changed: @caleb
mentioned in merge request !6148 (closed)
- Resolved by Joel Selvaraj
Nice, thank you!
One small issue regarding cameras: do you mind disabling the imx519 for now as discussed in !6148 (comment 471500)?
- Resolved by Joel Selvaraj
I think 6.14-dev misses the commits from https://gitlab.com/sdm845-mainline/linux/-/merge_requests/113, see https://gitlab.com/sdm845-mainline/linux/-/commits/sdm845%2F6.13-release
- Resolved by Clayton Craft
Works on fajita, both front and back camera are working and I'm not noticing any regressions. Did not test calls/texts. Camera focus via cameractrl does not appear to be working though. Exposure is working.
- Resolved by Joel Selvaraj
- Resolved by Dzmitry
I have an starqlte (samsung galaxy s9) laying around what should i test on it?, what is the status?
- Resolved by Dzmitry
@joelselvaraj starqltechn tested
marked the checklist item Samsung S9 (picked up a lot commits recently, so it will be nice to have it tested - @dsankouski) as completed
- Resolved by Robert Mader
Whops, accidentally posted this in !6148 (comment 472197):
@joelselvaraj: We may want to consider cherry-picking https://gitlab.com/sdm670-mainline/linux/-/commit/6889bc4fe90fc3f3b5d3e13a14954622fed2da46 (looks like it should apply cleanly) in order to power off the cameras when not streaming. This might fix some of the issues that otherwise need a Pipewire restart. I haven't tested it on sdm845, but it seems to work well on sdm670 (which generally has a more stable camera experience) and I hope it will get upstreamed.
IIUC right now the cameras stay on when used once (or already when PW starts?) until PW get restarted, which could well explain why they usually fail afterwards, sometimes sooner, sometimes later.
The patch was originally for lower power consumption, but could help. It can at least remove the need to restart Pipewire.
Edited by Robert Mader
added 1 commit
- 192b7660 - linux-postmarketos-qcom-sdm845: update to 6.14-rc5 and add cameras for op6
added 1 commit
- dbf7e93e - linux-postmarketos-qcom-sdm845: update to 6.14-rc5 and add cameras for op6
On the OP6 side, the camera's reset orientations are reversed and it shouldnt affect the functionality, But kindly give it a test. And, the IMX519 sensor is disabled as it is not currently working. There is another fix that "may" help with pipewire crashes on reopening camera app multiple times. So, I would suggest OP6 folks to give this MR one more try and then it is ready to be merged!
- Resolved by Clayton Craft
Just gave it a go on a OP6. There are still stability issues with the cameras when switching back and forth, requiring a PW restart to fix them. But from what I can see it's better than before and, crucially, only the working cameras are visible, meaning we have a nice switch button in Snapshot now.
Thus - and given that I don't see any regressions - I'd say:
it.
marked the checklist item Oneplus 6 (especially the camera setup) - @caleb or anyone from the testing team as completed