Skip to content
Snippets Groups Projects

main/linux-postmarketos-qcom: rename to linux-postmarketos-qcom-msm8974

Merged Imported Administrator requested to merge lpq-msm8974 into master
All threads resolved!

I mentioned this in https://gitlab.com/postmarketOS/pmaports/merge_requests/582 already, and there is justification for this change in the commit message and in https://gitlab.com/postmarketOS/pmaports/merge_requests/582#implementation ("Implementation").

From https://gitlab.com/postmarketOS/pmaports/merge_requests/582#note_210729198:

(linux-postmarketos-qcom is really more a linux-postmarketos-qcom-msm8974 at this point...)

It would be a good idea to rename it then, it would be great if you could submit a follow up MR after this one that does this change.

I tested building this locally since I suspect that CI will time out.

Edited by Administrator

Merge request reports

Approved by

Merged by AdministratorAdministrator 5 years ago (Oct 7, 2019 10:54pm UTC)

Merge details

  • Changes merged into master with a8551648.
  • Deleted the source branch.

Pipeline #199495 passed

Pipeline passed for a8551648 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
  • Administrator
  • Administrator
  • Administrator
  • Author Owner

    @konradybcio Although I appreciate your comments, they are in no way related to the change made in this MR. All I did is rename the existing package to give it a less confusing name. The switch from https://gitlab.com/postmarketOS/linux-postmarketos/commits/qcom to masneyb's fork was made in another MR, and all devices referencing linux-postmarketos-qcom now point to the masneyb fork, even without the changes in this MR.

    So I suggest that you open a new issue with your comments/suggestions and start discussing them separately.

    By Minecrell on 2019-10-06T14:16:50

    Edited by Administrator
  • Author Owner

    Indeed you are right, this was the wrong place to denote these things. I'm opening the issue at the time of writing this comment, otherwise the PR LGTM.

    By Konrad Dybcio on 2019-10-06T18:49:11

  • Administrator resolved all threads · Imported

    resolved all threads

    By Minecrell on 2019-10-06T22:29:14

  • Administrator added 22 commits · Imported

    added 22 commits

    • a387a1c2...0ff1dadc - 21 commits from branch postmarketOS:master
    • a8551648 - main/linux-postmarketos-qcom: rename to linux-postmarketos-qcom-msm8974 (!662)

    Compare with previous version

    By Oliver Smith on 2019-10-07T22:52:42

  • Author Owner

    Looks good to me, thank you @Minecrell!

    By Oliver Smith on 2019-10-07T22:53:00

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2019-10-07T22:53:03

  • Administrator enabled an automatic merge when the pipeline for a8551648 succeeds · Imported

    enabled an automatic merge when the pipeline for a8551648 succeeds

    By Oliver Smith on 2019-10-07T22:53:05

  • Administrator merged · Imported

    merged

    By Oliver Smith on 2019-10-07T22:54:24

  • Administrator mentioned in commit a8551648 · Imported

    mentioned in commit a8551648

    By Minecrell on 2019-11-04T13:02:39

  • Please register or sign in to reply
    Loading