hybris/pulseaudio-modules-droid: Fix compatibility with pulseaudio>=13.0

There were some API changes:

• https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/878ef440797f0fe319dcb1e866c29cec39b8a36d
• https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/6665b466d28ca6f166c22846777f541f5bc9cef7

Leading to:

• Error relocating /usr/lib/pulse-13.0/modules/libdroid-sink.so: pa_make_realtime: symbol not found
• Error relocating /usr/lib/pulse-13.0/modules/libdroid-source.so: pa_make_realtime: symbol not found
• Error relocating /usr/lib/pulse-13.0/modules/libdroid-source.so: pa_source_get_state: symbol not found

Fixes are:

• #include <pulse/util.h>, replace pa_make_realtime -> pa_thread_make_realtime
• replace pa_source_get_state(X) -> X->state
• replace pa_sink_get_state(X) -> X->state

Fixes !634 (merged)

added 1 deleted label

No relocation errors and audio is working again! Even Mer does not have this patch

By Alexey Min on 2019-10-06T20:53:37

changed the description

By Alexey Min on 2019-10-06T21:15:24

added 14 commits

• 683f16ec...0ff1dadc - 13 commits from branch postmarketOS:master
• edabf61c - hybris/pulseaudio-modules-droid: fix compatibility with pulseaudio>=13.0 (!667)

Compare with previous version

By Oliver Smith on 2019-10-07T22:38:23

approved this merge request

By Oliver Smith on 2019-10-07T22:40:17

Thanks @minlexx!

By Oliver Smith on 2019-10-07T22:40:39

enabled an automatic merge when the pipeline for edabf61c succeeds

By Oliver Smith on 2019-10-07T22:40:42

added 2 commits

• a8551648 - 1 commit from branch postmarketOS:master
• e9e60806 - hybris/pulseaudio-modules-droid: fix compatibility with pulseaudio>=13.0 (!667)

Compare with previous version

By Oliver Smith on 2019-10-07T22:56:42

merged

By Oliver Smith on 2019-10-07T22:57:08

approved this merge request

By Oliver Smith on 2019-10-07T22:57:09

Skipped slow CI (you just told me, that it is related to your setup). It already ran through in CI fine before, so this should be safe.

By Oliver Smith on 2019-10-07T22:57:40

This time my PR upstream was merged quickly with "slight modifications" and those modifications include some refactoring that was going in pulseaudio-modules-droid codebase. Keepalive module was split into a separate repo because if I understand correctly it is independent of droid parts. See also README update, it became a new dependency, dbus dep removal 1, 2.

But all whose changes are still not tagged, so I'll wait for new release (hopefully 13.0) before updating package and removing my patch.

By Alexey Min on 2019-10-09T09:21:53

mentioned in commit e9e60806

By Alexey Min on 2019-11-04T13:02:40