Skip to content
Snippets Groups Projects

zuk-z2-row: new device

Merged Imported Administrator requested to merge zuk-z2-row into master

Initial support for Lenovo ZUK Z2 Pro (zuk-z2-row)

https://wiki.postmarketos.org/wiki/Lenovo_ZUK_Z2_Pro_(zuk-z2-row)

Edited by Administrator

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Owner

    Another device with 4.4. kernel, yay!

    I suggest you merge all those patches that change include paths in multiple files into one single patch, and leave other patches (functionfs, nf_conntrack, sysctl_binary ones) as-is. It's just too many patches. And I'm curious what is sysctl_binary patch for?

    By Alexey Min on 2020-01-20T22:16:58

    Edited by Administrator
  • Administrator marked as a Work In Progress · Imported

    marked as a Work In Progress

    By Cui Hao on 2020-01-20T21:48:53

  • Administrator changed the description · Imported

    changed the description

    By Cui Hao on 2020-01-20T21:48:53

    • Author Owner
      Resolved by Administrator

      Oops, I'll fix these issues.

      sysctl_binary patch is to make the kernel compile with CONFIG_SYSCTL_SYSCALL set. But I don't think this option is useful anywhere and will remove it later.

      Compared to the original Android kernel config, I enabled many options in my kernel config, because I wanted to have a "generic-purpose" kernel. But I am not sure whether it is encouraged or not.

      A question. Is there a "standard" kernel config for postmarketOS?

      By Cui Hao on 2020-01-20T22:14:48

      Edited by Ghost User
  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Cui Hao on 2020-01-20T22:09:12

  • Author Owner

    Ideally you need to fix those linter warnings, too

    device/linux-zuk-z2-row/APKBUILD: MP:[AL32]:device/linux-zuk-z2-row/APKBUILD:26:unnecesary usage of braces: ${_flavor}
    MP:[AL32]:device/linux-zuk-z2-row/APKBUILD:26:unnecesary usage of braces: ${arch}
    MP:[AL32]:device/linux-zuk-z2-row/APKBUILD:28:unnecesary usage of braces: ${_commit}
    MP:[AL32]:device/linux-zuk-z2-row/APKBUILD:28:unnecesary usage of braces: ${_repository}
    MP:[AL32]:device/linux-zuk-z2-row/APKBUILD:42:unnecesary usage of braces: ${_commit}
    MP:[AL32]:device/linux-zuk-z2-row/APKBUILD:42:unnecesary usage of braces: ${_repository}
    firmware/firmware-zuk-z2-row/APKBUILD: MP:[AL32]:firmware/firmware-zuk-z2-row/APKBUILD:12:unnecesary usage of braces: ${_commit}
    MP:[AL32]:firmware/firmware-zuk-z2-row/APKBUILD:15:unnecesary usage of braces: ${_commit}

    I know, APKBUILD was generated like this by pmbootstrap, those CI checks are new, pmbootstrap is not adjusted yet.

    By Alexey Min on 2020-01-20T22:19:10

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Cui Hao on 2020-01-21T06:13:20

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Cui Hao on 2020-01-21T06:15:33

  • Administrator resolved all threads · Imported

    resolved all threads

    By Oliver Smith on 2020-01-26T20:52:59

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2020-01-26T20:53:37

  • Administrator unmarked as a Work In Progress · Imported

    unmarked as a Work In Progress

    By Oliver Smith on 2020-01-26T20:53:40

  • Administrator marked as a Work In Progress · Imported

    marked as a Work In Progress

    By Oliver Smith on 2020-01-26T20:54:31

  • Author Owner

    I've removed the WIP status by accident and then set it back. Is it still WIP? The patch looks good to me. As per our merge rules, it will need a second approval and will then be merged.

    Thank you very much for the port @cuihao.leo!

    By Oliver Smith on 2020-01-26T20:55:46

  • Administrator added 38 commits · Imported

    added 38 commits

    Compare with previous version

    By Cui Hao on 2020-01-27T04:27:58

  • Author Owner

    This time I tried to modulize as much drivers as possible.

    Currently, display (FB)/touchscreen/WiFi/USB work. Audio/bluetooth/camera are broken (or I don't know how to use it), and I have no idea how to fix. This is the best I can do for now. I'll remove the WIP status and let you decide whether to merge or not.

    By Cui Hao on 2020-01-27T04:53:57

  • Administrator unmarked as a Work In Progress · Imported

    unmarked as a Work In Progress

    By Cui Hao on 2020-01-27T04:54:27

  • Administrator approved this merge request · Imported

    approved this merge request

    By Alexey Min on 2020-01-27T23:13:15

  • Administrator added 2 commits · Imported

    added 2 commits

    Compare with previous version

    By Alexey Min on 2020-01-27T23:14:44

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading