Skip to content
Snippets Groups Projects

samsung-klte: add audio support for libhybris adaptation; some quality of life changes

Merged Imported Administrator requested to merge samsung-klte-downstream-upstreaming into master
  • move msm-fb-refresher dependency to downstream kernel package, it is useless on mainline kernel

  • disable msm-fb-refresher service when using libhybris adaptation, it is only required for downstream kernel without libhybris. It interferes with qcom kgsl-adreno driver badly (causes screen flickering)

  • set CPU governor to conservative on system startup (it lowers CPU frequency in idle state from initial 2.4 Ghz to 300 MHz)

  • add hybris_pulse subpackage that gets installed only when device-samsung-klte-hybris AND pulseaudio are installed. It pulls in pulseaudio-modules-droid-7.1-caf and alsa integration

  • add system.img symlink to lxc-android installation. With this you can have Android container successfully running already at the first boot without need to do it manually. Halium installation process puts your system.img to /data partition by default, so follow their recommendation. We can use a symlink to save some space on /system partition.

Merge request reports

Approval is optional

Merged by AdministratorAdministrator 5 years ago (Feb 22, 2020 8:51pm UTC)

Merge details

  • Changes merged into with 40c93fde.
  • Deleted the source branch.

Pipeline #198021 passed

Pipeline passed for 40c93fde on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator added category::device + 1 deleted label · Imported

    added category::device + 1 deleted label

  • Author Owner

    Awesome work! I can't test it as I don't have the device, but the changes look good. I like that you think of all the options (downstream without libhybris, downstream with libhybris, and mainline) as well. :thumbsup: from me.

    By Bart Ribbers on 2020-02-19T18:34:24

  • Administrator approved this merge request · Imported

    approved this merge request

    By Bart Ribbers on 2020-02-19T18:34:25

  • Author Owner

    I tested (old video, but nothing has changed since then regarding audio support in libhybris)

    GPU 3D acceleration (kwin_wayland-hwcomposer) is still a problem though, but one problem at a time

    By Alexey Min on 2020-02-19T23:49:24

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2020-02-22T20:15:26

  • Administrator added 42 commits · Imported

    added 42 commits

    Compare with previous version

    By Oliver Smith on 2020-02-22T20:15:41

  • Administrator enabled an automatic merge when the pipeline for 18b17f46 succeeds · Imported

    enabled an automatic merge when the pipeline for 18b17f46 succeeds

    By Oliver Smith on 2020-02-22T20:16:03

  • Author Owner

    CI is failing, because gitlab's tarball downloads are currently broken. I'll change CI to use "git clone --depth=1" instead for now, to install pmbootstrap (new MR).

    @minecrell also noted that we might want to use stable instead of master, but that needs further discussion and we did not found it important enough to have a proper issue about it. if somebody feels otherwise, please open a new issue with that topic and present your case.

    By Oliver Smith on 2020-02-22T20:31:46

  • Administrator aborted the automatic merge because target branch was updated · Imported

    aborted the automatic merge because target branch was updated

    By Oliver Smith on 2020-02-22T20:49:29

  • Administrator added 2 commits · Imported

    added 2 commits

    Compare with previous version

    By Oliver Smith on 2020-02-22T20:50:12

  • Administrator enabled an automatic merge when the pipeline for 40c93fde succeeds · Imported

    enabled an automatic merge when the pipeline for 40c93fde succeeds

    By Oliver Smith on 2020-02-22T20:50:26

  • Administrator merged · Imported

    merged

    By Oliver Smith on 2020-02-22T20:51:35

  • Administrator mentioned in commit 40c93fde · Imported

    mentioned in commit 40c93fde

    By Alexey Min on 2020-02-26T20:02:33

Please register or sign in to reply
Loading