WIP: new package lightdm-mobile-greeter

Just want some visibility it does do the login thing but it aint pretty, feel free to test at your peril. I felt this was needed because auto login is not a good thing so I'm providing a solution

main/lightdm-mobile-greeter/APKBUILD

+# Contributor: Raatty <me@raatty.club>
+# Maintainer: Raatty <me@raatty.club>
+pkgname="lightdm-mobile-greeter"
+pkgver="v0"
+pkgrel=0
+pkgdesc="A simple lightdm greeter for mobile"
+url="https://raatty.club:3000/raatty/lightdm-mobile-greeter"
+arch="noarch"
+license="MIT"
+depends="libhandy py3-gobject3 lightdm"
+source="${pkgname}-${pkgver}.tar.gz::https://raatty.club:3000/raatty/lightdm-mobile-greeter/archive/$pkgver.tar.gz"
+builddir="$srcdir/"
+options="!check"
+
+build() {
+        return 0
+}
+
+package() {
+	install -D "$srcdir"/lightdm-mobile-greeter/lightdm-mobile-greeter -t "$pkgdir"/usr/bin/
+        install -D "$srcdir"/lightdm-mobile-greeter/lightdm-mobile-greeter.desktop -t "$pkgdir"/usr/share/xgreeters/
+}
+
+sha512sums="23a117ef9749414221b60c06058b2630335948f204dced95f274a032fac4fac2bf775eebcb6afbe811e83734e242f331419976c270049805df4707de5532e619  lightdm-mobile-greeter-v0.tar.gz"

[Administrator]

I'm not sure this is a correct version

By Alexey Min on 2020-02-20T11:04:20

[Administrator]

It isn't. First of all there shouldn't be a letter, secondly it should be either 0.<some small number that is higher than 0> or 0_git<dateofcommit>. A package with version "0" isn't valid.

By Bart Ribbers on 2020-02-20T15:10:01

[Administrator]

but abuild didnt complain about the version...

By Raatty on 2020-02-20T18:52:20

[Administrator]

Still not Alpine's standards. Please fix it.

By Danct12 on 2020-02-20T18:54:05

[Administrator]

Fix the linter issues, it won't accept the unnecessary braces here.

By Bart Ribbers on 2020-02-20T12:33:49

[Administrator]

If this is specified, please also tell us why. A comment with # No tests is good enough.

By Bart Ribbers on 2020-02-20T12:34:31

[Administrator]

wow, and where are the actual build commands?

Oh, this is a python script, but I think even python scripts should have some installation procedure. We recently had merged python package in !946 (closed) , maybe you should do something similar?

By Alexey Min on 2020-02-20T11:04:20

[Administrator]

Tip: create new packages with pmbootstrap newapkbuild. It's help page (passing -h to it) shows there is a -y flag you can use to make a Python package. It'll add all the required basic stuff for Python packages.

By Bart Ribbers on 2020-02-20T12:32:20

[Administrator]

There are no build commands because this is a python script, not a python module. In that case the build() function can be left out.

By Martijn Braam on 2020-02-20T12:36:35

[Administrator]

when i was reading the apkbuild docs it said something about the build function being required and to just put return 0 if there is no build commands

By Raatty on 2020-02-20T18:56:03

[Administrator]

Well those docs are wrong then, it's not required. Only the package() function is required.

By Bart Ribbers on 2020-02-22T14:04:57

[Administrator]

-t is not needed. Also set the proper permissions for this and the next line, probably -Dm644 or -Dm755 depending on if you need it to be executable.

By Bart Ribbers on 2020-02-20T12:35:20