Skip to content
Snippets Groups Projects

pine64-pinephone: reset modem after changing audio configuration

Merged Imported Administrator requested to merge modem-boot-AT-routing into master
All threads resolved!

A bit unsure about setting the modem to "full functionality". Maybe I'd need to check current state, and only change it if it's already in that state? Though if another part of the system changes it later, they wouldn't think about resetting it, so I think this is fine.

This builds on !974 (closed), but resets the modem after. As this resets the modem, checks the audio configuration first.

Also ensure that this is executed before ofono.

Edited by Administrator

Merge request reports

Approved by

Merged by AdministratorAdministrator 5 years ago (Mar 21, 2020 8:43pm UTC)

Merge details

  • Changes merged into master with e638031a.
  • Deleted the source branch.

Pipeline #191850 passed

Pipeline passed for e638031a on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
  • Administrator resolved all threads · Imported

    resolved all threads

    By Mayeul C. on 2020-02-21T16:46:23

  • Administrator added 1 commit · Imported

    added 1 commit

    • 8406dc9f - pie64-pinephone: bump pkgrel

    Compare with previous version

    By Mayeul C. on 2020-02-21T16:48:36

  • Administrator added 3 commits · Imported

    added 3 commits

    • 4b01645a - pine64-pinephone: reset modem after applying configuration
    • 9659411d - pine64-pinephone: setup modem audio before starting ofono
    • 6a84baa5 - pie64-pinephone: bump pkgrel

    Compare with previous version

    By Mayeul C. on 2020-02-21T16:59:02

  • Administrator changed the description · Imported

    changed the description

    By Mayeul C. on 2020-02-25T11:03:36

  • Author Owner

    Just tested it, works great! Modem comes back around 10 seconds later

    [  199.677929] usb 3-1: USB disconnect, device number 2                                       
    [  199.678798] option1 ttyUSB0: GSM modem (1-port) converter now disconnected from ttyUSB0
    [  199.678908] option 3-1:1.0: device disconnected                            
    [  199.679721] option1 ttyUSB1: GSM modem (1-port) converter now disconnected from ttyUSB1
    [  199.679823] option 3-1:1.1: device disconnected         
    [  199.680681] option1 ttyUSB2: GSM modem (1-port) converter now disconnected from ttyUSB2
    [  199.680789] option 3-1:1.2: device disconnected         
    [  199.681745] option1 ttyUSB3: GSM modem (1-port) converter now disconnected from ttyUSB3    
    [  199.681850] option 3-1:1.3: device disconnected                                            
    [  199.689185] qmi_wwan 3-1:1.4 wwan0: unregister 'qmi_wwan' usb-1c1b000.usb-1, WWAN/QMI device
    [  211.160906] usb 3-1: new high-speed USB device number 3 using ehci-platform
    [  211.202590] option 3-1:1.0: GSM modem (1-port) converter detected        
    [  211.203047] usb 3-1: GSM modem (1-port) converter now attached to ttyUSB0                  
    [  211.203696] option 3-1:1.1: GSM modem (1-port) converter detected        
    [  211.206663] usb 3-1: GSM modem (1-port) converter now attached to ttyUSB1
    [  211.207394] option 3-1:1.2: GSM modem (1-port) converter detected                          
    [  211.210051] usb 3-1: GSM modem (1-port) converter now attached to ttyUSB2                  
    [  211.210780] option 3-1:1.3: GSM modem (1-port) converter detected                         
    [  211.213500] usb 3-1: GSM modem (1-port) converter now attached to ttyUSB3                  
    [  211.217195] qmi_wwan 3-1:1.4: cdc-wdm0: USB WDM device                                     
    [  211.218709] qmi_wwan 3-1:1.4 wwan0: register 'qmi_wwan' at usb-1c1b000.usb-1, WWAN/QMI device, 22:76:55:aa:07:1f

    By Luca Weiss on 2020-03-19T16:20:53

  • Administrator approved this merge request · Imported

    approved this merge request

    By Luca Weiss on 2020-03-19T16:20:58

  • Administrator added 158 commits · Imported

    added 158 commits

    Compare with previous version

    By Oliver Smith on 2020-03-21T20:38:09

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2020-03-21T20:38:11

  • Author Owner

    Rebased on master, and instead of having a separate pkgrel bump patch, I've increased the pkgrel in each patch (this is how it's usually done).

    Thanks for the awesome patch, @MayeulC! \o/

    By Oliver Smith on 2020-03-21T20:40:03

  • Administrator merged · Imported

    merged

    By Oliver Smith on 2020-03-21T20:43:53

  • Administrator mentioned in commit 3ca081f4 · Imported

    mentioned in commit 3ca081f4

    By Mayeul C. on 2020-03-26T14:57:49

  • Administrator mentioned in commit e638031a · Imported

    mentioned in commit e638031a

    By Mayeul C. on 2020-03-26T14:57:49

  • Please register or sign in to reply
    Loading