-
- Downloads
treewide: add a Chroot type and adopt pathlib.Path (MR 2252)
Introduce a new module: pmb.core to contain explicitly typed pmbootstrap API. The first component being Suffix and SuffixType. This explicitly defines what suffixes are possible, future changes should aim to further constrain this API (e.g. by validating against available device codenames or architectures for buildroot suffixes). Additionally, migrate the entire codebase over to using pathlib.Path. This is a relatively new part of the Python standard library that uses a more object oriented model for path handling. It also uses strong type hinting and has other features that make it much cleaner and easier to work with than pure f-strings. The Chroot class overloads the "/" operator the same way the Path object does, allowing one to write paths relative to a given chroot as: builddir = chroot / "home/pmos/build" The Chroot class also has a string representation ("native", or "rootfs_valve-jupiter"), and a .path property for directly accessing the absolute path (as a Path object). The general idea here is to encapsulate common patterns into type hinted code, and gradually reduce the amount of assumptions made around the codebase so that future changes are easier to implement. As the chroot suffixes are now part of the Chroot class, we also implement validation for them, this encodes the rules on suffix naming and will cause a runtime exception if a suffix doesn't follow the rules.
parent
b31dee9e
Branches
No related tags found
Showing
- pmb/__init__.py 3 additions, 2 deletionspmb/__init__.py
- pmb/aportgen/__init__.py 9 additions, 6 deletionspmb/aportgen/__init__.py
- pmb/aportgen/busybox_static.py 10 additions, 6 deletionspmb/aportgen/busybox_static.py
- pmb/aportgen/core.py 9 additions, 9 deletionspmb/aportgen/core.py
- pmb/aportgen/device.py 16 additions, 15 deletionspmb/aportgen/device.py
- pmb/aportgen/gcc.py 3 additions, 2 deletionspmb/aportgen/gcc.py
- pmb/aportgen/grub_efi.py 10 additions, 6 deletionspmb/aportgen/grub_efi.py
- pmb/aportgen/linux.py 8 additions, 7 deletionspmb/aportgen/linux.py
- pmb/aportgen/musl.py 10 additions, 6 deletionspmb/aportgen/musl.py
- pmb/build/_package.py 42 additions, 39 deletionspmb/build/_package.py
- pmb/build/autodetect.py 12 additions, 9 deletionspmb/build/autodetect.py
- pmb/build/checksum.py 8 additions, 4 deletionspmb/build/checksum.py
- pmb/build/envkernel.py 35 additions, 30 deletionspmb/build/envkernel.py
- pmb/build/init.py 27 additions, 28 deletionspmb/build/init.py
- pmb/build/kconfig.py 28 additions, 25 deletionspmb/build/kconfig.py
- pmb/build/newapkbuild.py 15 additions, 12 deletionspmb/build/newapkbuild.py
- pmb/build/other.py 38 additions, 33 deletionspmb/build/other.py
- pmb/chroot/apk.py 27 additions, 23 deletionspmb/chroot/apk.py
- pmb/chroot/apk_static.py 8 additions, 7 deletionspmb/chroot/apk_static.py
- pmb/chroot/binfmt.py 3 additions, 2 deletionspmb/chroot/binfmt.py
Loading