Skip to content
Snippets Groups Projects
Unverified Commit 39966f03 authored by Newbyte's avatar Newbyte :snowflake: Committed by Oliver Smith
Browse files

pmb.parse.apkindex: Improve parse_add_block() type hint (MR 2515)

I didn't really understand mypy's overloading well when I wrote this. It
makes sense to have a third overload here with bool as type for
multiple_providers used in circumstances where a literal isn't provided
for that parameter.
parent 978e6cf7
Branches
Tags
1 merge request!2515pmb.chroot.run: Add another overload for root() + pmb.parse.apkindex: Improve parse_add_block() type hint
Pipeline #216307 passed
......@@ -117,7 +117,7 @@ def parse_add_block(
ret: dict[str, ApkindexBlock],
block: ApkindexBlock,
alias: str | None = ...,
multiple_providers: bool = ..., # FIXME: Type should be Literal[False], but mypy complains?
multiple_providers: Literal[False] = ...,
) -> None: ...
......@@ -130,6 +130,15 @@ def parse_add_block(
) -> None: ...
@overload
def parse_add_block(
ret: dict[str, ApkindexBlock] | dict[str, dict[str, ApkindexBlock]],
block: ApkindexBlock,
alias: str | None = ...,
multiple_providers: bool = ...,
) -> None: ...
def parse_add_block(
ret: dict[str, ApkindexBlock] | dict[str, dict[str, ApkindexBlock]],
block: ApkindexBlock,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment