build: package: add warning for cyclical build dep (MR 2388)

Print a warning when breaking cyclical dependencies, for example with
current kde-nightly branch:

> WARNING: cyclical build dependency, building kirigami with binary package of qqc2-desktop-style

pmb/build/_package.py

@@ -268,9 +268,16 @@ def prioritise_build_queue(disarray: list[BuildQueueItem]) -> list[BuildQueueIte
                         # If a binary package exists for item, we can queue it
                         # safely and dep will be queued on a future iteration
                         if item["has_binary"]:
+                            logging.warning(
+                                f"WARNING: cyclical build dependency: building {item['name']} with binary package of {dep}"
+                            )
                             queue_item(item)
                             stuck = False
                             break
+                        else:
+                            logging.warning(
+                                "WARNING: cyclical build dependency: can't build {item['name']}, no binary package for {dep}"
+                            )
 
             if do_continue:
                 continue

[Administrator]

Uh, @ollieparanoid did you forget to make this a f-string?

Also why make an else if you're doing the same thing in the main if statement? Just log outside of the conditional statement entirely

By Bart Ribbers on 2024-09-18T13:27:52

[Administrator]

oh yes, I forgot the f infront of this f-string! fixed in 806d9a39

Also why make an else if you're doing the same thing in the main if statement?

The message is slightly different, "building" vs "can't build".

By Oliver Smith on 2024-09-18T14:34:43