Skip to content
Snippets Groups Projects
New look: Off

trailing comma in extra_packages seems to lead to "Newer version in binary..." error

    • Closed Imported Issue created by Administrator @root

    I'll post more details if needed but this probably just needs a check in Python. Just filter out empty strings from the array.

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    • Administrator
      Administrator @root · Imported
      Author Owner

      Created by: ollieparanoid

      I can reproduce this. We could fix this by either changing the validation regex in pmb/config/init.py (search for "Extra packages") or by implementing a check around the part where it asks for the extra packages (with a loop, see ask_for_hostname() in the same file).

      Would you like to take a shot at this?

      Thanks for reporting @raingloom! :thumbsup:

      By * postmarketOS Bot on 2018-06-07T06:24:33

    • Administrator
      Administrator @root · Imported
      Author Owner

      I think it could be desirable to edit the config file by hand, so it'd be better to do the check at both ends, ie. both when asking for them and when reading the config in.

      I'll take a shot at it uh, soon-ish?

      By Rain Gloom on 2018-06-16T19:08:26

      Edited by Ghost User
    • Administrator
      Administrator @root · Imported
      Author Owner

      Created by: ollieparanoid

      • You are right, having the checks when reading the config file in would be a good feature. Right now we don't do this for the other options, so if we add that it would be consistent to add it for all of them (probably requires some refactoring).
      • However, adding a check for the trailing comma should be easy.

      Yes, taking a shot at one of the above would be greatly appreciated! I'd start with the second, because it's much easier :thumbsup:

      By * postmarketOS Bot on 2018-06-16T21:40:20

    • Administrator mentioned in commit 7b40cbfb · Imported

      mentioned in commit 7b40cbfb

      By Oliver Smith on 2018-07-09T20:54:50

    • Administrator mentioned in commit 1d542feb · Imported

      mentioned in commit 1d542feb

      By Oliver Smith on 2018-07-09T21:11:11

    • Administrator mentioned in merge request !1632 (merged) · Imported

      mentioned in merge request !1632 (merged)

      By Oliver Smith on 2018-07-09T21:26:25

    • Administrator mentioned in commit 2c5cbbb9 · Imported

      mentioned in commit 2c5cbbb9

      By Oliver Smith on 2018-07-13T05:28:21

    • Administrator closed via merge request !1632 (merged) · Imported

      closed via merge request !1632 (merged)

      By Oliver Smith on 2018-07-13T05:38:30

    • Administrator closed via commit 2c5cbbb9 · Imported

      closed via commit 2c5cbbb9

      By Oliver Smith on 2018-07-13T05:38:30

    • Administrator mentioned in commit 563372fc · Imported

      mentioned in commit 563372fc

      By Oliver Smith on 2018-08-04T11:07:34

    Please register or sign in to reply