fastboot fails to do anything because of -i option
!857 (merged) introduced flash_fastboot_vendor_id
, which adds -i
option to fastboot's args. The problem is that -i
option got removed in https://android.googlesource.com/platform/system/core/+/f3192bd05231eb6d1c9307885c5400494e38527f%5E%21/ so pmbootstrap can't flash anything on devices that use fastboot. Error message is:
(022844) [13:06:10] (native) % fastboot -i flash userdata /home/pmos/rootfs/lg-hammerhead.img
fastboot: unrecognized option: i
There are two solutions:
- revert 6fb5b28e (might break flashing on amazon-thor)
- package older version of android-tools and use it if
flash_fastboot_vendor_id
is set (harder, but doesn't break anything)
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Author Owner
If we cannot test flashing on amazon-thor, we cannot reliably go with method 1. If we can, and it does not break flashing, then method 1 is fine
If we can't, OR it breaks the best would be method 2
By Alexey Min on 2019-09-26T14:43:07
Edited by Administrator - Author Owner
@steamport, you are the one who created port for amazon-thor in the first place, can you test if you can flash kernel without -i arg?
By Dolphin von Chips on 2019-09-26T12:09:55
Edited by Administrator - Administrator mentioned in commit 1d52f43c · Imported
mentioned in commit 1d52f43c
By Oliver Smith on 2019-09-26T20:46:53
- Author Owner
Let's do the easy fix and stop using -i. If somebody shows up who is actually using amazon-thor with postmarketOS (because @steamport has been inactive for quite some time), and they figure out that it does not work anymore, we can fix it for that device. The best fix would be convincing fastboot upstream, that the flag is still required, and patching it back in. Second best solution would be reverting the patch just in Alpine's fastboot package.
I'm preparing the related changes.
By Oliver Smith on 2019-09-26T20:49:46
- Administrator mentioned in commit 7b8dc01d · Imported
mentioned in commit 7b8dc01d
By Oliver Smith on 2019-09-26T20:56:04
- Administrator mentioned in commit pmaports@b6deac3f · Imported
mentioned in commit pmaports@b6deac3f
By Oliver Smith on 2019-09-26T21:02:25
- Administrator closed via merge request !1818 (merged) · Imported
closed via merge request !1818 (merged)
By Oliver Smith on 2019-09-26T21:02:31
- Administrator mentioned in commit wiki@56cc1338 · Imported
mentioned in commit wiki@56cc1338
By postmarketOS Wiki bot on 2019-09-26T21:43:11
- Author Owner
Potentially a user error, but was told to note this here:
OK: 265 MiB in 64 packages (000300) [02:44:57] (native) % apk --no-progress add android-tools OK: 265 MiB in 64 packages (000300) [02:44:57] (native) % apk --no-progress del .pmbootstrap (1/1) Purging .pmbootstrap (20190928.094453) OK: 265 MiB in 63 packages (000300) [02:44:58] % sudo mkdir -p /home/chelsea/.local/var/pmbootstrap/chroot_native/sys/bus/usb/devices/ (000300) [02:44:58] % sudo mount --bind /sys/bus/usb/devices/ /home/chelsea/.local/var/pmbootstrap/chroot_native/sys/bus/usb/devices/ (000300) [02:44:58] % sudo mkdir -p /home/chelsea/.local/var/pmbootstrap/chroot_native/sys/dev/ (000300) [02:44:58] % sudo mount --bind /sys/dev/ /home/chelsea/.local/var/pmbootstrap/chroot_native/sys/dev/ (000300) [02:44:58] % sudo mkdir -p /home/chelsea/.local/var/pmbootstrap/chroot_native/sys/devices/ (000300) [02:44:58] % sudo mount --bind /sys/devices/ /home/chelsea/.local/var/pmbootstrap/chroot_native/sys/devices/ (000300) [02:44:58] % sudo mkdir -p /home/chelsea/.local/var/pmbootstrap/chroot_native/dev/bus/usb/ (000300) [02:44:58] % sudo mount --bind /dev/bus/usb/ /home/chelsea/.local/var/pmbootstrap/chroot_native/dev/bus/usb/ (000300) [02:44:58] (native) % fastboot -c boot /mnt/rootfs_rockchip-rk3126/boot/boot.img-rockchip-rk3126 fastboot: unrecognized option: c
New port returns this error on latest commit (966d1a6d).
By rendeko on 2019-09-28T13:14:42
Edited by Ghost User Collapse replies - Author Owner
I'm afraid that -c got removed too, but this is can be fixed if we change
-c
to--cmdline
inpmb/config/__init__.py
at line 355. Perhaps creating a new issue? Might as well look at changelog to see what else is removed.By Dolphin von Chips on 2019-09-28T13:18:00
Edited by Administrator - Author Owner
Thanks for reporting, and for pointing me at the fix!
I've submitted the recommended change as !1819 (merged) and tested that it works with lg-mako. I am not sure if there even are changelogs, fastboot is just maintained as part of that bigger repository...
But I did write to the author of that patch and suggested to make future changes backwards compatible (i.e. keep -c instead of removing it). Maybe that helps.
By Oliver Smith on 2019-09-29T22:36:32
- Administrator mentioned in issue #1831 (closed) · Imported
mentioned in issue #1831 (closed)
By Oliver Smith on 2019-09-29T18:17:15