Skip to content
Snippets Groups Projects

Add initramfs error message when charging-sdl fails to run

Merged Imported Administrator requested to merge charging-mode-fail-msg into master

There are devices where charging-sdl/directfb fails (https://gitlab.com/postmarketOS/osk-sdl/issues/77).

It's nicer to give an error message than display "Loading..." forever.

Edited by Administrator

Merge request reports

Approved by

Merged by AdministratorAdministrator 6 years ago (Aug 14, 2018 2:12am UTC)

Merge details

  • Changes merged into master with b3803237.
  • Deleted the source branch.

Pipeline #188470 failed

Pipeline failed for b3803237 on master

Deployed to dep‎loy‎ 5 months ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Owner

    Tested on my Sony Xperia Z1 Compact (amami).

    By Marti Raudsepp on 2018-08-05T14:47:00

  • Administrator
  • Administrator added 1 commit · Imported

    added 1 commit

    • 782d1bfb - Add initramfs error message when charging-sdl fails to run

    Compare with previous version

    By Marti Raudsepp on 2018-08-05T15:35:33

  • Administrator added 1 commit · Imported

    added 1 commit

    • d6de8a83 - Add initramfs error message when charging-sdl fails to run

    Compare with previous version

    By Marti Raudsepp on 2018-08-05T15:45:13

  • Administrator changed the description · Imported

    changed the description

    By Marti Raudsepp on 2018-08-05T15:45:21

  • Author Owner

    I also documented the troubleshooting steps at https://wiki.postmarketos.org/wiki/Troubleshooting#CHARGING_MODE:_error_starting_charging-sdl

    By Marti Raudsepp on 2018-08-06T09:01:06

    Edited by Administrator
  • Administrator mentioned in commit wiki@b43401c7 · Imported

    mentioned in commit wiki@b43401c7

    By postmarketOS Wiki bot on 2018-08-05T16:42:36

  • Administrator
  • Administrator added 1 commit · Imported

    added 1 commit

    • 7355ed2d - Add initramfs error message when charging-sdl fails to run

    Compare with previous version

    By Marti Raudsepp on 2018-08-05T19:36:27

  • Administrator changed the description · Imported

    changed the description

    By Marti Raudsepp on 2018-08-05T19:37:58

  • Administrator added 1 commit · Imported

    added 1 commit

    • 34972f10 - Add initramfs error message when charging-sdl fails to run

    Compare with previous version

    By Marti Raudsepp on 2018-08-05T19:40:50

  • Administrator added 1 commit · Imported

    added 1 commit

    • b8da3c11 - Add initramfs error message when charging-sdl fails to run

    Compare with previous version

    By Marti Raudsepp on 2018-08-05T20:06:38

  • Administrator resolved all discussions · Imported

    resolved all discussions

    By Marti Raudsepp on 2018-08-05T20:18:34

  • Author Owner

    Looks okay to me, not sure about the CHARGING MODE header though

    By Craig Tatlor on 2018-08-07T16:09:16

  • Author Owner

    I agree with @opendata26, I think changing that to "Charging indicator" might be clearer for those that encounter this error. Especially since the phone should still be charging, it's just the indicator that doesn't work.

    By Martijn Braam on 2018-08-07T17:40:46

  • Author Owner

    Huh, replace "CHARGING MODE" with "Charging indicator"? So it would look like:

    Charging indicator

    error starting charging-sdl

    https://postmarketos.org/troubleshooting

    Sorry, makes no sense to me...

    By Marti Raudsepp on 2018-08-07T19:10:17

  • Author Owner

    @MartijnBraam Did you mean it like this?

    CHARGING MODE

    Error starting charging indicator

    By Marti Raudsepp on 2018-08-07T20:04:42

  • Author Owner

    Yeah I think that your original error is more clear, disregard my previous comment. It would be slightly neater if the splash generator could render an actual heading instead of uppercasing the first line but that's out of scope for this issue.

    Maybe this is even better?:

    CHARGING INDICATOR

    Error starting charging-sdl

    By Martijn Braam on 2018-08-08T20:13:47

    Edited by Administrator
  • Administrator approved this merge request · Imported

    approved this merge request

    By Martijn Braam on 2018-08-08T20:12:18

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading