install: explicitly install osk-sdl when needed
This adds osk-sdl to the rootfs when --fde is set, or when building a rootfs for the ondev installer. Ideally the ondev installer would selectively install osk-sdl if the user opted for fde at runtime, but I haven't found a straight forward way to enable that yet, and this behavior here is no different than the current behavior (where osk-sdl is always installed in the rootfs by way of depends= in pmos-mkinitfs).
For images that are built without --fde, osk-sdl won't be installed at all in the rootfs, once the dependency is dropped from pmos-mkinitfs in https://gitlab.com/postmarketOS/pmaports/-/merge_requests/2242
Merge request reports
Activity
added type::feature label
mentioned in commit pmaports@c9addc37
By clayton craft on 2021-06-10T06:52:37
mentioned in merge request pmaports!2242 (merged)
By clayton craft on 2021-06-10T06:53:30
mentioned in commit pmaports@540b1b9d
By clayton craft on 2021-06-10T06:56:57
mentioned in issue pmaports#1104 (closed)
By clayton craft on 2021-06-10T07:00:44
mentioned in commit pmaports@722d1be0
By clayton craft on 2021-06-11T16:33:00
mentioned in commit pmaports@0bef0c8b
By clayton craft on 2021-06-11T16:33:11
mentioned in commit pmaports@b0bba2db
By clayton craft on 2021-06-14T03:53:41
added 8 commits
-
4a4666c2...df9c61a8 - 7 commits from branch
master
- be0a6757 - install: explicitly install osk-sdl when needed (MR 2066)
By clayton craft on 2021-06-14T03:54:14
-
4a4666c2...df9c61a8 - 7 commits from branch
added 7 commits
-
be0a6757...5afc2e62 - 6 commits from branch
master
- 66f86810 - install: explicitly install osk-sdl when needed (MR 2066)
By clayton craft on 2021-06-16T23:02:35
-
be0a6757...5afc2e62 - 6 commits from branch
mentioned in commit pmaports@5eb7c395
By clayton craft on 2021-06-16T23:02:43
mentioned in commit pmaports@d1266138
By clayton craft on 2021-06-18T23:56:50
added 1 commit
- 21d00952 - install: add postmarketos-base-nofde package when not using fde
By clayton craft on 2021-06-18T23:56:59
mentioned in issue postmarketos-ondev#49
By Oliver Smith on 2021-06-19T13:16:50
- Resolved by Administrator
Great work! Please fix the pmaports.cfg guard and rebase on master so it passes CI (thanks for fixing the shellcheck thing). Other than that: LGTM!
Ideally the ondev installer would selectively install osk-sdl if the user opted for fde at runtime, but I haven't found a straight forward way to enable that yet
This is what I came up with, let's do it after the current pmaports and pmbootstrap MRs are merged (as they are useful in current state already):
https://gitlab.com/postmarketOS/postmarketos-ondev/-/issues/49
By Oliver Smith on 2021-06-19T13:29:09
mentioned in commit pmaports@1d78b5cb
By clayton craft on 2021-06-25T16:11:25
added 6 commits
-
21d00952...6afd35eb - 5 commits from branch
master
- 31e36e19 - install: explicitly install osk-sdl when needed (MR 2066)
By clayton craft on 2021-06-25T19:28:40
-
21d00952...6afd35eb - 5 commits from branch
mentioned in commit pmaports@0f1c765e
By clayton craft on 2021-06-26T23:33:52