Drop support for python3.7 and python3.8 and migrate to pyproject.toml

Even Debian oldstable is on python3.9 now, so should be safe, and should also help the typing process that has now started.

Regarding the migration to pyproject.toml, the only thing that seems to be relevant, is that now the helpers are installed under usr/lib/python3.11/site-packages/helpers/ which I guess we should change. I'm unfortunately not exactly sure how.

added type::feature label

approved this merge request

By Robert Eckelmann on 2024-02-23T06:28:57

Python 3.8 is still technically receiving security updates upstream until later this year: https://devguide.python.org/versions/

But it has like half a year of life left and like you're implying, I doubt many people are using it any more either. So in that regard at least this looks fine by me.

By Newbyte on 2024-02-24T13:09:31

I tried building this via pip.

On Fedora 39 (Python 3.12.1, pip 23.2.1), it works like you'd expect:

$ pip install .
Defaulting to user installation because normal site-packages is not writeable
Processing /mnt/storage/Programming/pmbootstrap
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: pmbootstrap
  Building wheel for pmbootstrap (pyproject.toml) ... done
  Created wheel for pmbootstrap: filename=pmbootstrap-2.2.1-py3-none-any.whl size=251077 sha256=ee553d29904efc9a61574af2eeae974cd1c5cc7d89f7cdbc8debee77183ac1d8
  Stored in directory: /tmp/pip-ephem-wheel-cache-8vdqqvlb/wheels/33/4a/4f/f40ab342e89b21a4c26a4197b2db22c7ee8f83fd8aa09f80d4
Successfully built pmbootstrap
Installing collected packages: pmbootstrap
Successfully installed pmbootstrap-2.2.1

But on Ubuntu 22.04 (Python 3.10.12, pip 22.0.2), it does this:

$ pip install .
Defaulting to user installation because normal site-packages is not writeable
Processing /run/host/mnt/storage/Programming/pmbootstrap
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: UNKNOWN
  Building wheel for UNKNOWN (pyproject.toml) ... done
  Created wheel for UNKNOWN: filename=UNKNOWN-0.0.0-py3-none-any.whl size=13293 sha256=4fc8057761a687056fe7f1815ad57cefe3dac9afd1c34141a17712acb525e262
  Stored in directory: /tmp/pip-ephem-wheel-cache-8co57f1r/wheels/3b/32/d5/426c1747b33ab8d93bd8b355f130f3b9da055745e4b025c33e
Successfully built UNKNOWN
Installing collected packages: UNKNOWN
Successfully installed UNKNOWN-0.0.0

I'm not sure what's going on honestly. Maybe bugs in the outdated pip? But it's probably not something we need to care about?

By Newbyte on 2024-02-28T23:36:45

Glad to see that we're finally switching to a declarative project configuration!

By Newbyte on 2024-02-24T13:19:18

resolved all threads

By Pablo Correa Gomez on 2024-02-26T18:01:12

added 3 commits

• 318dc0db - Migrate from setup.py to pyproject.toml
• 65b657c9 - Drop support for python3.7 and python3.8
• 43ef2fe0 - Remove unnecessary setup.cfg, non-universal is the default

Compare with previous version

By Pablo Correa Gomez on 2024-02-26T18:02:35

very nice!

Even Debian oldstable is on python3.9 now, so should be safe, and should also help the typing process that has now started.

yup, this is reasonable :)

By Oliver Smith on 2024-02-28T23:32:34

added 6 commits

• 43ef2fe0...812a3e4a - 3 commits from branch master
• dcece6d5 - Migrate from setup.py to pyproject.toml
• 08a42c48 - Drop support for python3.7 and python3.8
• 46411849 - Remove unnecessary setup.cfg, non-universal is the default

Compare with previous version

By Pablo Correa Gomez on 2024-02-28T23:47:46

Thanks for the review! Would be nice to for the typing work to have this

By Pablo Correa Gomez on 2024-02-28T23:48:21

approved this merge request

By Oliver Smith on 2024-02-29T00:14:18

resolved all threads

By Oliver Smith on 2024-02-29T00:14:30

added 3 commits

• d895f4a4 - Migrate from setup.py to pyproject.toml (MR 2265)
• d2bcff31 - Drop support for python3.7 and python3.8 (MR 2265)
• 762c725b - Remove unnecessary setup.cfg, non-universal is the default (MR 2265)

Compare with previous version

By Oliver Smith on 2024-02-29T00:15:08

enabled an automatic merge when the pipeline for 762c725b succeeds

By Oliver Smith on 2024-02-29T00:15:28

merged