Skip to content
Snippets Groups Projects

yet more fixes

Merged Imported Administrator requested to merge caleb/cache-type-warn-once into master
1 unresolved thread
  • Add a warn_once() log function
  • Simplify repo update() caching with warn_once()
  • Don't dump a stack trace to the console in please_i_really_need_args()
  • Adjust chroot outdated warning to be more informative and warn about all chroot's early on
  • type hint cached functions better
  • don't switch to pmaports master from the systemd branch during pmb init
Edited by Administrator

Merge request reports

Checking pipeline status.

Approved by

Merged by AdministratorAdministrator 9 months ago (Jul 8, 2024 2:18pm UTC)

Merge details

  • Changes merged into master with 0e62eaac.
  • Did not delete the source branch.

Pipeline #187801 passed

Pipeline passed for 0e62eaac on master

Deployed to dep‎loy‎ 6 months ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Owner

    LGTM, although CI needs to pass before we can merge it. Thanks for making this!

    By Oliver Smith on 2024-07-03T14:59:27

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2024-07-03T14:59:27

  • Administrator approved this merge request · Imported

    approved this merge request

    By Robert Eckelmann on 2024-07-04T21:38:56

  • Administrator added 13 commits · Imported

    added 13 commits

    • dd0d4384...a57b338e - 7 commits from branch master
    • 68673ea7 - helpers: logging: add warn_once()
    • 3e79f620 - helpers: repo: drop cache key in update
    • f41b862a - helpers: args: improve please_i_really_need_args() logging
    • 437f734c - config: workdir: make chroots_outdated() return a list
    • ce35984e - chroot: init: build a nice log message for outdated chroots
    • eb68f443 - meta: cache: fix type hinting on cached functions

    Compare with previous version

    By Caleb Connolly on 2024-07-07T20:39:05

  • Author Owner

    argh, type hinting sucks :(

    the caching stuff seems to have pushed mypy to it's limits here. not really sure how to tackle this, nothing I try seems to work.

    By Caleb Connolly on 2024-07-07T22:11:26

  • Administrator added 6 commits · Imported

    added 6 commits

    • ec01baf1 - install: partition: drop unused args
    • a4a1b864 - helpers: toml: fix mypy on import
    • 5c09b42a - fixup! meta: cache: fix type hinting on cached functions
    • 559604e8 - helpers: mount: fix rootfs mount path
    • 1fcc6e25 - helpers: package: overload types
    • ace274a8 - treewide: another round of mypy fixes

    Compare with previous version

    By Caleb Connolly on 2024-07-08T13:58:45

  • Administrator marked this merge request as draft from 5c09b42a · Imported

    marked this merge request as draft from 5c09b42a

    By Caleb Connolly on 2024-07-08T13:58:46

  • Administrator added 11 commits · Imported

    added 11 commits

    • cb1dc805 - 1 earlier commit
    • 97fd688a - helpers: repo: drop cache key in update
    • a76558a3 - helpers: args: improve please_i_really_need_args() logging
    • df5d5636 - config: workdir: make chroots_outdated() return a list
    • 88f8f90b - chroot: init: build a nice log message for outdated chroots
    • 110554e1 - meta: cache: fix type hinting on cached functions
    • e5115475 - install: partition: drop unused args
    • 26911c30 - helpers: toml: fix mypy on import
    • 1bbb8f14 - helpers: mount: fix rootfs mount path
    • 315e8ab5 - helpers: package: overload types
    • a2e5df78 - treewide: another round of mypy fixes

    Compare with previous version

    By Caleb Connolly on 2024-07-08T14:01:21

  • Administrator added 1 commit · Imported

    added 1 commit

    • ab84f3db - config: don't switch to edge from systemd

    Compare with previous version

    By Caleb Connolly on 2024-07-08T14:07:04

  • Administrator marked this merge request as ready · Imported

    marked this merge request as ready

    By Caleb Connolly on 2024-07-08T14:07:37

  • Administrator changed title from Draft: helpers: logging: add warn_once() to yet more fixes · Imported

    changed title from Draft: helpers: logging: add warn_once() to yet more fixes

    By Caleb Connolly on 2024-07-08T14:07:37

  • Administrator changed the description · Imported

    changed the description

    By Caleb Connolly on 2024-07-08T14:07:37

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Caleb Connolly on 2024-07-08T14:09:47

  • Administrator resolved all threads · Imported

    resolved all threads

    By Caleb Connolly on 2024-07-08T14:15:27

  • Administrator added 13 commits · Imported

    added 13 commits

    • d73214cf...95d68d88 - 3 earlier commits
    • 62fa40e1 - config: workdir: make chroots_outdated() return a list (MR 2344)
    • 5881d01c - chroot: init: build a nice log message for outdated chroots (MR 2344)
    • f794b36f - meta: cache: fix type hinting on cached functions (MR 2344)
    • 6301212d - install: partition: drop unused args (MR 2344)
    • 7741f74d - helpers: toml: fix mypy on import (MR 2344)
    • afbecb71 - helpers: mount: fix rootfs mount path (MR 2344)
    • 852efe1f - helpers: package: overload types (MR 2344)
    • 65d23905 - treewide: another round of mypy fixes (MR 2344)
    • 71646f0a - config: don't switch to edge from systemd (MR 2344)
    • 0e62eaac - ruff: format (MR 2344)

    Compare with previous version

    By Caleb Connolly on 2024-07-08T14:16:55

  • Administrator enabled an automatic merge when all merge checks for 0e62eaac pass · Imported

    enabled an automatic merge when all merge checks for 0e62eaac pass

    By Caleb Connolly on 2024-07-08T14:17:07

  • Administrator merged · Imported

    merged

  • Please register or sign in to reply
    Loading