Skip to content

Draft: pmb.install.losetup: Avoid using --json parameter for losetup in detach_all()

Newbyte requested to merge newbyte/avoid-json-detach-all into master

The default losetup implementation in Alpine and thus postmarketOS is BusyBox losetup. It doesn't support the --json parameter, and so unless the util-linux variant gets installed this code path won't work. Installing additional packages during shutdown doesn't seem like a great approach to me as it makes this code path more fragile and completely breaks it if e.g. your Internet is out, so just bring back the old code from shutdown.py in pmbootstrap 2.3.1 to do this job for us.

Co-developed-by: Oliver Smith ollieparanoid@postmarketos.org

Fixes 0975d064

Closes #2465 (closed) Supersedes: !2435 (closed)

@craftyguy, @caleb, @ollieparanoid does this seem reasonable to you?

Merge request reports