Skip to content
Snippets Groups Projects

parse: apkindex: fix provider_priority never actually being an int

Merged Caleb Connolly requested to merge caleb/apkindex-fix-and-test into master
All threads resolved!

provider_priority was actually a string all along! make it an int as type hinting suggests, and add some tests for apkindex parsing.

cc: @Newbyte

Merge request reports

Merge request pipeline #208820 failed

Merge request pipeline failed for 6066772c

Approved by

Merged by Caleb ConnollyCaleb Connolly 5 months ago (Oct 23, 2024 9:23pm UTC)

Merge details

  • Changes merged into master with 6066772c.
  • Did not delete the source branch.

Pipeline #208822 failed

Pipeline failed for 6066772c on master

Deployed to dep‎loy‎ 5 months ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Newbyte
  • Thanks for adding the apkindex tests! Much appreciated.

  • Caleb Connolly added 3 commits

    added 3 commits

    • 4109ebea - parse: apkindex: fix provider_priority type
    • 32993e62 - test: parse: add test_apkindex
    • 0f51d826 - CI: ruff: run ALLL the checks before failing

    Compare with previous version

  • Caleb Connolly added 3 commits

    added 3 commits

    • 56ac891c - parse: apkindex: fix provider_priority type
    • 0aabb649 - test: parse: add test_apkindex
    • c06ad7a7 - CI: ruff: run ALLL the checks before failing

    Compare with previous version

  • Caleb Connolly resolved all threads

    resolved all threads

  • Newbyte approved this merge request

    approved this merge request

  • Clayton Craft approved this merge request

    approved this merge request

  • code changes in pmb/parse/apkindex.py lgtm

  • Newbyte
  • Robert Eckelmann approved this merge request

    approved this merge request

  • Caleb Connolly resolved all threads

    resolved all threads

  • Caleb Connolly added 10 commits

    added 10 commits

    • c06ad7a7...37ec73c0 - 5 commits from branch master
    • 05cfcd2d - test: chroot: apk: fix missing return in _apkindex_package()
    • 8c210a27 - core: drop unused crosstool.py
    • b11f9f35 - parse: apkindex: fix provider_priority type
    • da7ad712 - test: parse: add test_apkindex
    • 7e60e1ab - CI: ruff: run ALLL the checks before failing

    Compare with previous version

  • Caleb Connolly added 5 commits

    added 5 commits

    • b1518719 - test: chroot: apk: fix missing return in _apkindex_package() (MR 2448)
    • da78b11d - core: drop unused crosstool.py (MR 2448)
    • a874025b - parse: apkindex: fix provider_priority type (MR 2448)
    • 8627ee7e - test: parse: add test_apkindex (MR 2448)
    • 6066772c - CI: ruff: run ALLL the checks before failing (MR 2448)

    Compare with previous version

  • Please register or sign in to reply
    Loading