Skip to content

Fix various build issues (fix #189, and probably #341)

Administrator requested to merge fix/various-build-issues into master

Created by: ollieparanoid

Even if this does not fix #341 (closed), it should turn a crash into a warning.

Changes:

  • Removed the apkindex_files cache. That particular cache caused bug #189 (closed) and didn't bring any real-world performance improvements (tested 3x with that cache and 3x without, no significant speed difference). I decided to remove it instead of keeping it/adding even more code to resolve the bug.
  • Fix the check for already built packages: always use the architecture, that the package should be built for instead of the architecture of the build environment (e.g. use armhf, even when building a noarch package in the x86_64 chroot). This partially resolves #341 (closed).
  • Make pmb.chroot.apk.install_is_necessary() more robust: If the binary package is missing, although it should be there, print a warning and build it with force.

@antonok-edm: It would be awesome if you could try out this PR and confirm whether it fixes #189 (closed) for you. In my testing it did. @PureTryOut: I'd like to know if this fixes #341 (closed) for you.

Merge request reports

Loading