Skip to content
Snippets Groups Projects

CI: fix markdownlint script

Merged Casey requested to merge caleb/markdownlint-for-real into main
All threads resolved!

Since the while loop ran in a subshell, changes to the MDL_FAILED variable aren't visible to the parent, so the job always succeeded. Woops

Fix it and reflow markdown to pass. I highly recommend using an IDE plugin for markdownlint while working on markdown files as it can show inline warnings (in vscode if you turn them on!). A markdown formatter is also good ("format document" in vscode).

Merge request reports

Merge request pipeline #216414 passed

Merge request pipeline passed for 14c8243f

Merged by Pablo Correa GomezPablo Correa Gomez 1 month ago (Feb 28, 2025 11:09pm UTC)

Merge details

  • Changes merged into main with 14c8243f.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pablo Correa Gomez resolved all threads

    resolved all threads

  • Pablo Correa Gomez approved this merge request

    approved this merge request

  • added 2 commits

    • f028a88f - CI: fix markdownlint script
    • 14c8243f - treewide: actually pass markdownlint

    Compare with previous version

  • Thanks for being on top of these details!

  • Please register or sign in to reply
    Loading