Install fails when trying to bind mount files

When the installer tries to bind mount files here, this fails when trying to install on samsung-degaswifi using twrp-3.7.0_9-0-degas.img. The end of the pmos.log file is this:

+ umount /tmp/postmarketos/chroot/pmos.log
umount: can't umount /tmp/postmarketos/chroot/pmos.log: Invalid argument
+ rm /tmp/postmarketos/chroot/pmos.log
+ touch /tmp/postmarketos/chroot/pmos.log
+ umount /tmp/postmarketos/chroot/pmos.zip
umount: can't umount /tmp/postmarketos/chroot/pmos.zip: Invalid argument
+ rm /tmp/postmarketos/chroot/pmos.zip
+ touch /tmp/postmarketos/chroot/pmos.zip
+ mount --bind /tmp/postmarketos/pmos.log /tmp/postmarketos/chroot/pmos.log
mount: mounting /tmp/postmarketos/pmos.log on /tmp/postmarketos/chroot/pmos.log failed: Invalid argument

The reason appears to be that that this version of twrp uses a version of busybox that does not support file linking. See https://bugs.busybox.net/show_bug.cgi?id=11601

When I changed the lines to copy the files into chroot instead, I was finally able to get it to install.

changed the description

By Edward Beroset on 2024-02-01T13:34:18

I also ran into this issue and the suggested fix also worked for me. To add some more detail if anyone else runs into this issue, here's exactly how to fix it:

Locate the recovery zip, extract it, and make the following change to pmos_chroot:

# Mount the logfile and pmos.zip so we can access it inside the chroot
# for file in "pmos.log" "pmos.zip"; do
#	{ umount "$CHROOT"/"$file" ; rm "$CHROOT"/"$file" ; } || :
#	touch "$CHROOT"/"$file"
# done
# mount --bind /tmp/postmarketos/pmos.log "$CHROOT"/pmos.log
# mount --bind "$ZIP" "$CHROOT"/pmos.zip

cp /tmp/postmarketos/pmos.log "$CHROOT"/pmos.log
cp "$ZIP" "$CHROOT"/pmos.zip

mentioned in issue pmaports#3163