Skip to content
Snippets Groups Projects

CI: various improvements

Merged Imported Administrator requested to merge improve-ci into master
All threads resolved!

Make it possible to run all CI scripts via pmbootstrap ci and other CI related fixes.

  • CI: shellcheck: make pmbootstrap ci compatible
  • CI: shellcheck: ignore SC3043 (instead of ignoring it inline every time)
  • CI: let install_pmbootstrap.sh do pmb init
  • CI: upgrade-compat: make pmbootstrap ci compatible
  • CI: upgrade-compat: set default UI=none
  • CI: upgrade-compat: fix 2x chroot still active msg

See commit messages for details.

Merge request reports

Checking pipeline status.

Approved by

Merged by AdministratorAdministrator 1 year ago (May 7, 2023 7:39pm UTC)

Merge details

  • Changes merged into master with e1d70560.
  • Deleted the source branch.

Pipeline #142965 passed

Pipeline passed for e1d70560 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
  • Administrator
  • Author Owner

    Two small comments about being able to run scripts outside pmbootstrap, but this all looks good. Feel free to merge, even ignoring feedback, certainly not critical.

    By Pablo Correa Gomez on 2023-05-07T17:13:26

  • Administrator approved this merge request · Imported

    approved this merge request

    By Pablo Correa Gomez on 2023-05-07T17:13:26

  • Administrator added 9 commits · Imported

    added 9 commits

    • 1a6c5693 - 1 commit from branch master
    • dbb85cbf - CI: shellcheck: make pmbootstrap ci compatible (MR 12)
    • 1182ef7e - CI: shellcheck: ignore SC3043 (MR 12)
    • 5abfbc50 - CI: let install_pmbootstrap.sh do pmb init (MR 12)
    • 471e6b5c - CI: upgrade-compat: make pmbootstrap ci compatible (MR 12)
    • 2226bd71 - CI: upgrade-compat: set default UI=none (MR 12)
    • 0f9eec88 - CI: upgrade-compat: fix 2x chroot still active msg (MR 12)
    • 1d9c46f4 - CI: shellcheck: check if it is installed (MR 12)
    • e1d70560 - CI: upgrade-compat: check if pmb is installed (MR 12)

    Compare with previous version

    By Oliver Smith on 2023-05-07T19:35:26

  • Author Owner

    Thanks for the review! Pushed two more commits to address your review points. These were trivial so I'll merge it after CI passes.

    By Oliver Smith on 2023-05-07T19:37:18

  • Administrator resolved all threads · Imported

    resolved all threads

    By Oliver Smith on 2023-05-07T19:37:36

  • Administrator enabled an automatic merge when the pipeline for e1d70560 succeeds · Imported

    enabled an automatic merge when the pipeline for e1d70560 succeeds

    By Oliver Smith on 2023-05-07T19:38:16

  • Administrator merged · Imported

    merged

  • Author Owner

    Lovely! Two good improvements to the CI for sure!

    By Pablo Correa Gomez on 2023-05-07T21:52:45

  • Please register or sign in to reply
    Loading