Don't print the "Session already set to" message if the new session is
the same as the old one. That way it doesn't get printed anymore
whenever upgrading one of the postmarketos-ui-* packages that use
tinydm.

XDG_CURRENT_DESKTOP is currently being set by other display
managers by using the DesktopNames entry in the session file.
Unfortunately, this step is not clearly documented[1][2][3],
but seems to be the way other display managers are setting
the variable.

[1] https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html
[2] https://github.com/lumina-desktop/lumina/issues/520
[3] https://bugs.freedesktop.org/show_bug.cgi?id=85938

XDG_SESSION_DESKTOP is a desktop identifier which is expected
to be set by the display manager and handed to the logind[1].
The logic to set the name is extracted from gdm and matches
the environment variable set in phosh.service[2] when being
started without a display manager

[1] https://www.freedesktop.org/software/systemd/man/pam_systemd.html
[2] https://gitlab.gnome.org/World/Phosh/phosh/-/blob/main/data/phosh.service#L35

part of https://gitlab.com/postmarketOS/postmarketos/-/issues/26

Fix crash if /etc/tinydm.d/env-wayland.d dir exists (as created by
Makefile) but is empty:

  tinydm: sourcing file: /etc/tinydm.d/env-wayland.d/*
  /usr/bin/tinydm-run-session: .: line 38: can't open '/etc/tinydm.d/env-wayland.d/*': No such file or directory

Fixes: a7b0eaf3 ("Add support for sourcing env profiles based on session type")

Clayton Craft authored 3 years ago and Oliver Smith committed 3 years ago

This adds the ability to source any files under
/etc/tinydm.d/$session_type.d, where session_type is either x11 or
wayland. The intention is to allow users to specify variables that
should only be set for specific session types and not others, e.g.
`MOZ_ENABLE_WAYLAND=1` or `SDL_VIDEODRIVER=wayland`.

$XDG_STATE_HOME is new in the XDG Base Directory specification and
defines where "state files" should be stored. This includes things like
history and log files. If $XDG_STATE_HOME is either empty or not set it
defaults to ~/.local/state
Let's move our log file to this new location

Source: https://www.reddit.com/r/linux/comments/ny34vs/new_xdg_state_home_in_xdg_base_directory_spec/
Original proposal: https://lists.freedesktop.org/archives/xdg/2016-December/013803.html
Spec: https://specifications.freedesktop.org/basedir-spec/latest/ar01s03.html

Quoted from the spec:

"The $XDG_STATE_HOME contains state data that should persist between (application) restarts, but that is not important or portable enough to the user that it should be stored in $XDG_DATA_HOME. It may contain:
 - actions history (logs, history, recently used files, …)
 - current state of the application that can be reused on a restart (view, layout, open files, undo history, …)"

Sometimes the DE crashes, causing tinydm to immediately restart. When
this happens, any useful info in the log file is overwritten and lost
forever. This change causes tinydm to save the log file from the
previous session. It only saves N-1 logs.

This behavior is similar to what X11 does with Xorg.0.log and
Xorg.0.log.old.

postmarketos-ondev doesn't need dbus or elogind to be installed,
therefore tinydm should not have a hard dependency on them. With 'want',
they will be started if installed, but tinydm will not fail to start up
if they aren't installed.

Related: https://github.com/OpenRC/openrc/blob/master/service-script-guide.md#the-depend-function

Restore functionallity of sourcing profile, as it was removed in
autologin:
https://git.sr.ht/~kennylevinsen/autologin/commit/3f3a40c773dbcd229de66a006a2f2a17c6608afa

Oliver Smith authored 4 years ago and Clayton Craft committed 4 years ago

startx needs the absolute executable path, otherwise it will not
recognize the executable as command to be executed. It would fall back
to "xterm" as executable and interpret everything else as arguments to
xterm. Weird script.

Oliver Smith authored 4 years ago and Clayton Craft committed 4 years ago

run_session_x will need to modify one of the arguments in the follow-up
patch, so pass $cmd as multiple arguments instead of a single argument.
Do the same with run_session_wayland for consistency.

Oliver Smith authored 4 years ago and Clayton Craft committed 4 years ago

This file isn't supposed to be executed from within the repository.

Oliver Smith authored 4 years ago and Clayton Craft committed 4 years ago

They are in /usr/share/xsessions, not x-sessions.

Related: https://pkgs.alpinelinux.org/contents?file=&path=%2Fusr%2Fshare%2Fx-sessions&name=&branch=edge
Related: https://pkgs.alpinelinux.org/contents?file=&path=%2Fusr%2Fshare%2Fxsessions&name=&branch=edge

we use it in postmarketOS edge already :)

Clayton Craft authored 4 years ago and Oliver Smith committed 4 years ago

This moves the log file out of root of $HOME and into either the
$XDG_CACHE_DIR or ~/.cache (per freedesktop basedir spec)

Clayton Craft authored 4 years ago and Oliver Smith committed 4 years ago

This uses a user uid from openrc's conf.d to configure autologin. If
none is set, it defaults to using uid 1000 (selected because I had to
pick something..)

Lifted from other pmOS projects :D

This tests whether an existing session exists, and prompts to overwrite
it.

This appears to be the last of the TODOs listed in this file, so I've
removed the TODO comment.

The logic to (not) let the UI display an initial lockscreen did not take
gnome-keyring and kwallet into account (which need to be unlocked with
the user's password). Remove this logic, let Phosh always display the
lockscreen for now.

Related: https://gitlab.com/postmarketOS/pmaports/-/issues/823#note_433581347

And remove link to pmaports.git branch. It's mentioned in the issue.

This option is required for some DEs (e.g., Phosh) to be cleaned up fully so
they aren't automatically restarted by a child process.