xfce4-phone: further improvements

Changes:

• Replace "Battery Monitor" by "Power Manager Plugin" (pmaports#1317)
• Fix the lower panel
• Change clock format from "1:23" to "01:23"
• Make font DPI changable for device package post-install scripts (pmaports#293)
• Reset list of keyboard shortcuts to default
• Remove brightness-switch properties from configs

Details on the changes:

The "Power Manager Plugin" offers more options than "Battery Monitor", let's replace it (pmaports#1317).

The lower panel currently has a "squeezed" size. When changing the size in the settings, it "jumps" to the correct size. This is because no size is defined yet in the configs. The MR assigns a size rightaway.

Additionally, the first three launchers had a wrong content in the config and therefore appeared as empty lauchers. It is now set to the same lauchers as in original Xfce4 (https://gitlab.xfce.org/xfce/xfce4-panel/-/blob/xfce-4.16/migrate/default.xml.in). With one exception: The terminal launcher starts in maximized mode. On phones this is more convenient.

The clock format "01:23", having a fixed length, seems more appropriate then "1:23" when embedded in the panel surrounded by icons.

Implementing the font DPI in the configs does not change anything actually. However, having the value in the configs allows it to be overwritten by device packages post-install scripts. That way devices with high resolution screens can be assigned a larger text representation on Xfce4 installation (pmaports#293).

The list of keyboard shortcuts in Settings -> Keyboards -> Application Shortcuts was quite reduced. When hitting the "Reset to Default" button, it became much bigger. Let's set it to the defaults at installation. Same for the keyboard shortcuts of the windows manager.

Concering the brightness-switch properties, the value "-1" for brightness-switch-restore-on-exit seemed wrong. However, it's better not to speficy this in the configs, that way the defaults will be used.

Regarding DPI, I don't think we should use post-install in device packages to change it. See the comment here: https://gitlab.com/postmarketOS/pmaports/-/issues/293#note_752855484

With that being said, explicitly setting the default to 96, which is the implicit default already, probably doesn't hurt / can be reverted easily if needed. So let's not block the MR over this.

The rest looks good, and I assume you have tested everything properly.

Merging and tagging the release.

Thanks a lot @jakko, these are great improvements!

By Oliver Smith on 2021-12-05T22:41:19

Regarding DPI, I don't think we should use post-install in device packages to change it.

No problem.

As you said, it doesn't hurt if that line is in the configs. We can improve that later on.

Thanks for merging and creating the tag!

By Jakko on 2021-12-05T22:41:19

added 7 commits

• c13f10c3 - Replace "Battery Monitor" by "Power Manager Plugin" (MR 8)
• d28ffdc8 - Fix the lower panel (MR 8)
• 7faf1dcc - Change clock format from "1:23" to "01:23" (MR 8)
• c23281e3 - Make font DPI changable for device package post-install scripts (MR 8)
• e178ea12 - Reset list of keyboard shortcuts to default (MR 8)
• e8e89ceb - Remove brightness-switch properties from configs (MR 8)
• ac0d7063 - Update screenshot in README.md (MR 8)

Compare with previous version

By Oliver Smith on 2021-12-05T20:49:39

approved this merge request

By Oliver Smith on 2021-12-05T20:49:50

merged