Skip to content
Snippets Groups Projects

WIP: Generate nice looking pages for the directories containing the images

Closed Imported Administrator requested to merge feature/image-dir-styling into master
5 unresolved threads

Screenshots:

image

image

Closes: #78 (closed)

Edited by Administrator

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Owner

    Nice!

    How about changing the link colors? I don't know why, but for some reason I really dislike the default colors. (And I'm not sure if we do need visited links to be different. Many pages don't do that, and we also don't for the pmOS website.)

    By Oliver Smith on 2021-01-24T21:17:47

  • Administrator
9 9 import bpo.images
10 10
11 11
12 def write_header(path, title):
12 def write_header(path, title, dirname):
13 13 """ Write a header.html, as our nginx configuration expects it to exist for
14 14 each directory.
15 15 :param path: full path to where it will get saved
16 16 :title: what to put in the <title> tag """
  • Administrator
  • 30 td.size, td.date {
    31 display: none;
    32 }
    33 </style>
    34 </head>
    35 <body>
    36 <header>
    37 <img src="https://postmarketos.org/logo.svg">
    38 <span>postmarketOS</span>
    39 </header>
    40 <br style="clear: both;">
    41 <main>
    42 <p>
    43 This is the postmarketOS images server. Device images for supported devices will be generated here by
    44 the postmarketOS build system at <a href="https://build.postmarketos.org/">build.postmarketos.org</a>.
    45 </p>
    • Author Owner

      Everything above is repeated in 3 files. Can you change the code, so it uses one shared include?

      (I think jinja templates support includes too FWIW.)

      By Oliver Smith on 2021-01-24T21:17:48

    • Please register or sign in to reply
  • Administrator
  • 35 <body>
    36 <header>
    37 <img src="https://postmarketos.org/logo.svg">
    38 <span>postmarketOS</span>
    39 </header>
    40 <br style="clear: both;">
    41 <main>
    42 <p>
    43 This is the postmarketOS images server. Device images for supported devices will be generated here by
    44 the postmarketOS build system at <a href="https://build.postmarketos.org/">build.postmarketos.org</a>.
    45 </p>
    46 <p>
    47 Available devices in the <strong>{{dirname}}</strong> release channel (<a href="..">All channels</a>):
    48 </p>
    49 </main>
    50 <h1 style="display: none">
  • Administrator changed the description · Imported

    changed the description

    By Oliver Smith on 2021-02-18T19:49:44

    • Author Owner

      So the nginx directory listing cuts off the file names, which is unfortunate because the file names of the images are pretty long. How about we simply generate one index.html instead of the header.html and readme.html? (maybe generate empty files for them if nginx writes 404 errors otherwise)

      By Oliver Smith on 2021-02-24T23:11:45

    • Author Owner

      Regarding the look of the page: how about we base it off build.postmarketos.org? it's kind of similar to the regular website, but more minimalistic. Important parts for me would be free space on the left and right, and a clearly distinguished header from the rest of the page (like the pmOS logo on black background @ bpo).

      By Oliver Smith on 2021-02-24T23:14:12

  • Author Owner

    Obsoleted by !26 (merged).

    By Oliver Smith on 2021-06-29T09:39:11

  • Administrator closed · Imported

    closed

  • Please register or sign in to reply
    Loading